Player Owned House AABB

[Mark7625]

So in POH the dungeons and above does not respect the area you define this i think this because of

1. You cant define a range of planes eg 1-3 for the main POH and 0 for dungeon as 0 will just span everything, in the overworld this is correct but in this case its not

We should do something like

"planes": {
        "type": "array",
        "description": "Restrict the area to specific planes. A single value [1] restricts to only plane 1. A range [1,3] restricts to planes 1 through 3 (inclusive). This overrides the plane ranges specified in regionBoxes and aabbs.",
        "items": {
          "type": "integer"
        },
        "minItems": 1,
        "maxItems": 2
      }

2. the instance stuff does not respect the player height

In the dungeon the player is on plane 0 but the tile is copied from plane 1

as seen here, again this is fine with overworld but causes issues in instances i have checked other instances also same issue

[aHooder]

We could make regionBoxes support a third parameter to define a range of planes also, but what's the issue you're seeing here? Are you trying to apply tile overrides, model overrides or environments, or something else? Our AABBs typically test against the coordinates translated into template chunk coordinates, which for the POH is ofc jumbled all over the place. That's why we have just a simple regionbox spanning all of it atm.

[Jin-Jiyunsun]

I was trying to set a skybox for the dungeon level of the poh, but since you can place rooms down there that usually would be on the surface (portal nexus ect) it was impossible to set a dark underground skybox without it effecting the normal surface versions of the rooms, since they just copy from the same area regardless of if its going to be on the surface, upstairs or dungeon

And so I asked Mark how GPU handles this as they do have a different skybox for surface and dungeon and this is what he came up with

[aHooder]

Ah I see. Afaik this is actually possible already, but the annoying part is you would have to map out all template chunks for every possible dungeon room. With that, it should work, I think. I'm guessing RuneLite's skybox plugin already has these mapped out at least partially. It seems like they might have all non-dungeon rooms mapped out manually, so it considers them part of the overworld. This portion maybe? Not sure: https://github.com/runelite/runelite/blob/96215657ffdfea7b787207031abbc5bca3a66e9d/runelite-client/src/main/resources/net/runelite/client/plugins/skybox/skybox.txt#L895-L1036

[Jin-Jiyunsun]

I tried mapping out the corridors but then the issue was the skills hall at the bottom of the stairs was still considered overworld

[Mark7625]

Ah I see. Afaik this is actually possible already, but the annoying part is you would have to map out all template chunks for every possible dungeon room. With that, it should work, I think. I'm guessing RuneLite's skybox plugin already has these mapped out at least partially. It seems like they might have all non-dungeon rooms mapped out manually, so it considers them part of the overworld. This portion maybe? Not sure: https://github.com/runelite/runelite/blob/96215657ffdfea7b787207031abbc5bca3a66e9d/runelite-client/src/main/resources/net/runelite/client/plugins/skybox/skybox.txt#L895-L1036

when i was looking the issue was the dungeons was on plane 0 and everything else was plane 1+ hence why i thought a range be better since we just presume 0+ height is always the same environment atm since it kinda is in the overworld, granted i did not look for ages, the player and the environment plane is different and i think our aabb goes off player no ? i could be wrong tho

[aHooder]

It's based on the player's position atm, yeah. The issue is we translate it from instance coords to world coords I think, so the coord ends up in the mess of jumbled up rooms which the POH is assembled from. We could add special handling for POH though.

[Mark7625]

It's based on the player's position atm, yeah. The issue is we translate it from instance coords to world coords I think, so the coord ends up in the mess of jumbled up rooms which the POH is assembled from. We could add special handling for POH though.

Ye think just handling for poh be best bit as its just the odd case it does not work for :D