Skip to content

Commit 4aea7fc

Browse files
authored
Merge pull request #126 from 1lck/codex/fix-windows-package-args-main
fix(ci): bind Windows packaging arguments by name
2 parents 73ad8a1 + 280ebac commit 4aea7fc

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/release-preview-windows.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ jobs:
9090
LITHE_WINDOWS_TIMESTAMP_SERVER: ${{ secrets.WINDOWS_TIMESTAMP_SERVER }}
9191
WINDOWS_RELEASE_SIGNED: ${{ steps.signing.outputs.signed }}
9292
run: |
93-
$packageArgs = @(
94-
"-Configuration", "Release",
95-
"-Version", $env:LITHE_VERSION
96-
)
93+
$packageArgs = @{
94+
Configuration = "Release"
95+
Version = $env:LITHE_VERSION
96+
}
9797
if ($env:WINDOWS_RELEASE_SIGNED -eq "true") {
98-
$packageArgs += "-RequireAuthenticodeSignature"
98+
$packageArgs.RequireAuthenticodeSignature = $true
9999
} else {
100100
Write-Output "Packaging an unsigned Windows preview installer."
101101
}

.github/workflows/release-windows.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ jobs:
8888
LITHE_WINDOWS_TIMESTAMP_SERVER: ${{ secrets.WINDOWS_TIMESTAMP_SERVER }}
8989
WINDOWS_RELEASE_SIGNED: ${{ steps.signing.outputs.signed }}
9090
run: |
91-
$packageArgs = @(
92-
"-Configuration", "Release",
93-
"-Version", $env:LITHE_VERSION
94-
)
91+
$packageArgs = @{
92+
Configuration = "Release"
93+
Version = $env:LITHE_VERSION
94+
}
9595
if ($env:WINDOWS_RELEASE_SIGNED -eq "true") {
96-
$packageArgs += "-RequireAuthenticodeSignature"
96+
$packageArgs.RequireAuthenticodeSignature = $true
9797
} else {
9898
Write-Output "Packaging an unsigned Windows installer."
9999
}

0 commit comments

Comments
 (0)