Refactor type definitions in audit and routes for improved clarity and type safety. Replace Prisma imports with local type annotations and enhance metadata handling in audit logs to use a more flexible Record type.

Author: 24Skater

backend/src/lib/audit.ts

@@ -1,12 +1,12 @@
-import { Prisma } from '@prisma/client'
 import prisma from './prisma.js'
 
 interface AuditLogData {
   actorUserId?: string | null
   action: string
   entityType: string
   entityId?: string | null
-  metadata?: Prisma.InputJsonValue
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  metadata?: Record<string, any>
 }
 
 /**

backend/src/routes/messages.ts

@@ -1,6 +1,5 @@
 import { Router, Request, Response } from 'express'
 import { z } from 'zod'
-import { Prisma } from '@prisma/client'
 import prisma from '../lib/prisma.js'
 import { requireAuth, requirePermission } from '../middleware/auth.js'
 import { getProviderForChannel } from '../providers/messaging/index.js'
@@ -11,9 +10,6 @@ type MessageChannel = 'email' | 'sms'
 type MemberStatus = 'active' | 'inactive' | 'visitor'
 type DeliveryStatus = 'pending' | 'sent' | 'failed'
 
-// Type for Prisma transaction client
-type TransactionClient = Prisma.TransactionClient
-
 const router = Router()
 
 // ============================================
@@ -232,7 +228,7 @@ router.post('/', requireAuth, requirePermission('communications.send'), async (r
     }
 
     // Create message and recipients in a transaction
-    const message = await prisma.$transaction(async (tx: TransactionClient) => {
+    const message = await prisma.$transaction(async (tx) => {
       const newMessage = await tx.message.create({
         data: {
           channel: channel as MessageChannel,

backend/src/routes/sales.ts

@@ -1,17 +1,10 @@
 import { Router } from 'express'
 import { z } from 'zod'
-import { Prisma } from '@prisma/client'
 import prisma from '../lib/prisma.js'
 import { requireAuth, requirePermission } from '../middleware/auth.js'
 import { JwtPayload } from '../lib/auth.js'
 import { createAuditLog } from '../lib/audit.js'
 
-// Type for Prisma transaction client
-type TransactionClient = Prisma.TransactionClient
-
-// Infer Product type from Prisma client
-type Product = Prisma.ProductGetPayload<Record<string, never>>
-
 const router = Router()
 
 // Zod schemas
@@ -39,7 +32,7 @@ router.post('/', requireAuth, requirePermission('sales.edit'), async (req, res)
     const user = req.user as JwtPayload
 
     // Use a transaction to ensure atomicity
-    const result = await prisma.$transaction(async (tx: TransactionClient) => {
+    const result = await prisma.$transaction(async (tx) => {
       // Generate sale number within transaction
       const saleNumber = await (async () => {
         const year = new Date().getFullYear()
@@ -69,7 +62,7 @@ router.post('/', requireAuth, requirePermission('sales.edit'), async (req, res)
         throw new Error('One or more products not found')
       }
 
-      const productMap = new Map<string, Product>(products.map((p) => [p.id, p]))
+      const productMap = new Map(products.map((p: typeof products[0]) => [p.id, p] as const))
 
       // Calculate line items and subtotal
       let subtotalCents = 0
@@ -251,7 +244,7 @@ router.post('/:id/void', requireAuth, requirePermission('sales.edit'), async (re
     const user = req.user as JwtPayload
 
     // Use transaction for atomicity
-    const result = await prisma.$transaction(async (tx: TransactionClient) => {
+    const result = await prisma.$transaction(async (tx) => {
       const sale = await tx.sale.findUnique({
         where: { id },
         include: {