Skip to content

Use new Store interface from express-rate-limit v6 #40

Description

@gamemaker1

Hi @okv,

I recently helped out with a Typescript rewrite for the express-rate-limit package, which also introduced a couple of changes to the Store interface:

As the external tests show, the store still works (without any changes) with v6 of express-rate-limit. However, implementing the newer Store interface allows for the following:

I would be happy to open/help out with a PR that implements the new Store interface.

Also, I see that #27 is still open and there is no @types/rate-limit-mongo package. Would you like this PR to also:

  1. Rewrite the library in Typescript, OR
  2. Add a type definition file (index.d.ts like what @gtmsingh has suggested in Typescript declaration #27 (comment)) so that Typescript users don't encounter errors while using this library.

Please let me know your thoughts on the above.

Thanks,
Vedant

// cc @nfriedly

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions