Skip to content

parseFinalResults doesn't add all dice results - only the most recent #8

Description

@RobertTate

Just curious if this could be considered a possible future feature / improvement:

When I put the raw results value from onRollComplete into DiceResults.showResults, I can include logic that would let me add additional die to the roll using .add, and the DiceResults display would update the math and append the additional die into the calculation display.

However, the raw results value isn't calculating things like + or - modifiers into the display result. parseFinalResults fixes this, showing the correct final value. The only downside though is that it doesn't allow for the same type of appending functionality if you're .adding dice to the roll. Instead, it overwrites the previous value.

Could there be a way to adjust/extend parseFinalResults, so that it could allow for a continuous display of all rolls being made?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions