Necessity of TangDis fallback in ConstDisVelAccPress predictor and importance of predicting velocities and accelerations in the static time integration #1893
danielwolff1
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
While implementing a new predictor, I was wondering about the necessity of having a
TangDisfallback predictor when employing a predictor of typeConstDisVelAccPress.The
TangDisfallback predictor is only triggered in this line which according to the coverage report basically never happens. But it has a lot of implications, also for other classes, i.e., the different kinds of time integrations: The return values of the time integrations' methodspredict_const_acc()andpredict_const_vel_consist_acc()have been changed fromvoidtobool, even though they almost always returntrue.The only exception to this is the time integration class for static simulations
Statics. Here, the return values indicate whether enough history information is available to reconstruct meaningful velocity and acceleration vectors and then theTangDisfallback predictor is only used if this is not the case.However, this brings up the question of how meaningful the definition of global velocity and acceleration vectors in a static simulation is, which is why I wanted to ask here, whether anyone knows about a case where
vel_n,acc_n,vel_np, oracc_npare meaningfully used in stationary simulations?If not, I would propose to remove the
TangDisfallback predictor from theConstDisVelAccPressclass and change the return values of thepredict_const_acc()andpredict_const_vel_consist_acc()methods in the time integration classes back tovoidwhich would then again be consistent with the signature ofpredict_const_dis_consist_vel_acc().All reactions