[Feature Request] PDF support

[jspizziri]

Add the ability to view PDF files in addition to the other currently supported formats.

[jspizziri]

@adesege, I'd recommend starting here.

Most of the library's implementation has been taken straight from the TestApps in the swift-tooklit and kotlin-tookit.

For instance, if you compare the ios/Reader structure in this library to the TestApp/Sources/Reader structure in the swift-tooklit, you'll see that they are nearly identical. The key difference is that I've stripped out everything that the the library doesn't currently support.

So the task here would be to port over the code in the Reader/PDF folder (but obviously for both Android and iOS).

Does that make sense?

[adesege]

@jspizziri I will compare the repos and add PDF functionality. I will raise a PR as soon as I have something tangible to show.

Thanks.

[adesege]

Hi @jspizziri,

I've been able to add PDF support for Android. However, there seems to be a performance issue with my implementation. You can check the changes here https://github.com/5-stones/react-native-readium/compare/main...adesege:react-native-readium:add-pdf?expand=1

Let me know what you think.

Thanks.

[jspizziri]

@adesege can you create an MR for it? We'll obviously want to make sure the performance issue gets resolved (you're not using an android emulator are you?). Additionally, we'll need an iOS implementation as well.

[jspizziri]

@adesege any updates on your PR?

[adesege]

Hi @jspizziri, apologies for the delayed response. I've been quite busy with work.

I just cloned the repo but I'm unable to get the example app working. The app gets installed on the device but it doesn't open the book.

I've tried creating a new example app and just copy the javascript code to it but it didn't make any difference.

[jspizziri]

@adesege I'm not able to reproduce your issue with the example app. Can you add some more info on the steps you've taken?

[adesege]

@jspizziri It started working again some hours ago. I didn't change anything.

The issue I was having with the example app was that the metro bundler was not able to reload the app on a device.

Thanks