feat: update java to 24 and fix windows issues

Author: 89iuv

pom.xml

@@ -12,10 +12,10 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
-        <maven.compiler.source>21</maven.compiler.source>
-        <maven.compiler.target>21</maven.compiler.target>
+        <maven.compiler.source>24</maven.compiler.source>
+        <maven.compiler.target>24</maven.compiler.target>
 
-        <javafx-controls.version>21.0.4</javafx-controls.version>
+        <javafx-controls.version>24.0.2</javafx-controls.version>
 
         <TarsosDSP.version>2.5</TarsosDSP.version>
         <slf4j-api.version>2.0.16</slf4j-api.version>

src/main/java/com/lazydash/audio/visualizer/Main.java

@@ -79,8 +79,8 @@ public void start(Stage primaryStage) throws Exception {
 
     @Override
     public void stop() throws Exception {
-        AppConfig.windowHeight = stage.getHeight();
-        AppConfig.windowWidth = stage.getWidth();
+        AppConfig.windowHeight = (int) Math.round(stage.getHeight());
+        AppConfig.windowWidth = (int) Math.round(stage.getWidth());
         AppConfig.windowX = stage.getX();
         AppConfig.windowY = stage.getY();
         configFilePersistence.persist(AppConfig.class, CONFIG_VISUALIZER_APPLICATION_PROPERTIES);
@@ -146,11 +146,11 @@ private Stage createStage(Parent root) throws IOException {
         });
 
         stage.heightProperty().addListener((observable, oldValue, newValue) -> {
-            AppConfig.windowHeight = newValue.doubleValue();
+            AppConfig.windowHeight = newValue.intValue();
         });
 
         stage.widthProperty().addListener((observable, oldValue, newValue) -> {
-            AppConfig.windowWidth = newValue.doubleValue();
+            AppConfig.windowWidth = newValue.intValue();
         });
 
         // set opacity

src/main/java/com/lazydash/audio/visualizer/core/audio/FFTAudioProcessor.java

@@ -10,6 +10,7 @@
 import com.lazydash.audio.visualizer.system.config.AppConfig;
 import org.hipparchus.analysis.UnivariateFunction;
 import org.hipparchus.analysis.interpolation.AkimaSplineInterpolator;
+import org.hipparchus.analysis.interpolation.LinearInterpolator;
 import org.hipparchus.analysis.interpolation.UnivariateInterpolator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

src/main/java/com/lazydash/audio/visualizer/core/audio/TarsosAudioEngine.java

@@ -34,7 +34,7 @@ public void start() {
 
             int buffer = (int) (audioWindowSize * (sampleRate / 1000.0d));
 
-            TargetDataLine line = getLine(audioFormat, buffer);
+            TargetDataLine line = getLine(audioFormat, buffer * 2);
             run(line, audioFormat, buffer, 0);
 
         } catch (LineUnavailableException e) {

src/main/java/com/lazydash/audio/visualizer/system/config/AppConfig.java

@@ -22,7 +22,7 @@ public class AppConfig {
     public static int minBarHeight = 2;
     public static int barGap = 1;
 
-    public static double maxBarHeight = 352;
+    public static int maxBarHeight = 352;
     public static int hzLabelHeight = 20;
 
     // spectral color
@@ -43,8 +43,8 @@ public class AppConfig {
 
     // window
     public static boolean windowDecorations = true;
-    public static double windowWidth = 1700;
-    public static double windowHeight = 400;
+    public static int windowWidth = 1700;
+    public static int windowHeight = 400;
     public static double windowX = -1;
     public static double windowY = -1;
     public static boolean enableHoverOpacity = false;

src/main/java/com/lazydash/audio/visualizer/ui/code/spectral/SpectralView.java

@@ -6,17 +6,15 @@
 import javafx.geometry.Insets;
 import javafx.geometry.Pos;
 import javafx.geometry.VPos;
+import javafx.scene.effect.BlendMode;
 import javafx.scene.layout.*;
-import javafx.scene.paint.Color;
-import javafx.scene.paint.CycleMethod;
-import javafx.scene.paint.LinearGradient;
-import javafx.scene.paint.Stop;
+import javafx.scene.paint.*;
 import javafx.scene.text.Font;
 
 import java.util.ArrayList;
 import java.util.List;
 
-public class SpectralView extends GridPane {
+public class SpectralView extends HBox {
     private final List<FrequencyView> frequencyViewList = new ArrayList<>();
     private final Color backgroundColor = Color.TRANSPARENT;
     private final Background background = new Background(new BackgroundFill(backgroundColor, CornerRadii.EMPTY, Insets.EMPTY));
@@ -46,10 +44,6 @@ public void configure() {
                     CornerRadii.EMPTY, new BorderWidths(1), Insets.EMPTY)));
         }
 
-        RowConstraints rowConstraintsAmplitudes = new RowConstraints();
-        rowConstraintsAmplitudes.setVgrow(Priority.NEVER);
-        this.getRowConstraints().add(rowConstraintsAmplitudes);
-
         this.heightProperty().addListener((observable, oldValue, newValue) -> {
             AppConfig.maxBarHeight = newValue.intValue() - AppConfig.hzLabelHeight;
         });
@@ -79,9 +73,9 @@ public void updateState(List<FrequencyBar> frequencyBarList) {
     }
 
     private void updateBars(List<FrequencyBar> frequencyBarList) {
-        this.setHgap(AppConfig.barGap);
+        this.setSpacing(AppConfig.barGap);
 
-        double rectangleWidth = (this.getWidth() / (frequencyViewList.size() + 1) - AppConfig.barGap);
+        double rectangleWidth = (this.getWidth() / (frequencyViewList.size()) - (AppConfig.barGap * 2));
 
         for (int i = 0; i < frequencyViewList.size(); i++) {
             FrequencyView frequencyView = frequencyViewList.get(i);
@@ -102,6 +96,7 @@ private void updateBars(List<FrequencyBar> frequencyBarList) {
                 frequencyView.getShadow().setWidth(rectangleWidth);
             } else {
                 frequencyView.getShadow().setHeight(0);
+                frequencyView.getShadow().setWidth(rectangleWidth);
             }
 
             frequencyView.getRectangle().setFill(frequencyBar.getColor());
@@ -125,17 +120,14 @@ private void createBars(List<FrequencyBar> frequencyBarList) {
 
             VBox amplitudeVBox = new VBox();
             amplitudeVBox.setAlignment(Pos.BOTTOM_CENTER);
+            amplitudeVBox.setSpacing(-2);
             amplitudeVBox.getChildren().add(frequencyView.getShadow());
             amplitudeVBox.getChildren().add(frequencyView.getRectangle());
-            this.add(amplitudeVBox, i, 0);
+            amplitudeVBox.getChildren().add(frequencyView.getHzLabel());
 
-            VBox hzVBox = new VBox();
-            hzVBox.setAlignment(Pos.BOTTOM_CENTER);
-            hzVBox.getChildren().add(frequencyView.getHzLabel());
-            this.add(hzVBox, i, 1);
+            this.getChildren().add(amplitudeVBox);
 
-            GridPane.setValignment(frequencyView.getRectangle(), VPos.BOTTOM);
-            GridPane.setHalignment(frequencyView.getHzLabel(), HPos.CENTER);
+            HBox.setMargin(this, Insets.EMPTY);
         }
     }
 }

src/main/resources/ui/fxml/settings/settings.fxml

@@ -8,7 +8,7 @@
             fx:controller="com.lazydash.audio.visualizer.ui.fxml.settings.SettingsController">
 
     <left>
-        <VBox id="side-bar">
+        <VBox id="side-bar" minWidth="200">
             <VBox fx:id="sideBarSettings">
 
             </VBox>