Hi @dadelforge, really great work on this package! For the JOSS review, my sense is that the first 2 paragraphs of the "Statement of need" more closely fall under "Implementation details", or even belong in a section with its own header describing the mathematical background.
The last paragraph is a perfect fit for the statement of need. Perhaps restate the first sentence as "SSA is a nonparametric method which provides a low-assumption framework..." so that it sounds better as the first sentence of the section.
Lastly it would be great to add one sentence explicitly stating the target audience, as in listing of a few domains where time series analysis is highly prevalent (e.g. physics, neuroscience, meteorology, finance...)
Hi @dadelforge, really great work on this package! For the JOSS review, my sense is that the first 2 paragraphs of the "Statement of need" more closely fall under "Implementation details", or even belong in a section with its own header describing the mathematical background.
The last paragraph is a perfect fit for the statement of need. Perhaps restate the first sentence as "SSA is a nonparametric method which provides a low-assumption framework..." so that it sounds better as the first sentence of the section.
Lastly it would be great to add one sentence explicitly stating the target audience, as in listing of a few domains where time series analysis is highly prevalent (e.g. physics, neuroscience, meteorology, finance...)