Jim asked on #431 issue for the atol=1e-8 in InstanceBasedAttack to be globally defined, alongside whatever StructuralAttack uses for equivalence classes
InstanceBasedAttack uses np.allclose(atol=1e-8), StructuralAttack uses np.unique(axis=0) exact equality, so before extracting a constant I wanted to check whether you would like one shared tolerance across attacks, or two distinct constants with different semantics
@rpreen what do you think
Jim asked on #431 issue for the
atol=1e-8inInstanceBasedAttackto be globally defined, alongside whateverStructuralAttackuses for equivalence classesInstanceBasedAttackusesnp.allclose(atol=1e-8),StructuralAttackusesnp.unique(axis=0)exact equality, so before extracting a constant I wanted to check whether you would like one shared tolerance across attacks, or two distinct constants with different semantics@rpreen what do you think