Skip to content

chore: define shared atol semantics across attacks #454

@shamykyzer

Description

@shamykyzer

Jim asked on #431 issue for the atol=1e-8 in InstanceBasedAttack to be globally defined, alongside whatever StructuralAttack uses for equivalence classes

InstanceBasedAttack uses np.allclose(atol=1e-8), StructuralAttack uses np.unique(axis=0) exact equality, so before extracting a constant I wanted to check whether you would like one shared tolerance across attacks, or two distinct constants with different semantics

@rpreen what do you think

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions