Skip to content

DoctrineAdapter OpenIDAuthorizationCodeInterface issue #16

@schrotteh

Description

@schrotteh

Hey there,
I'm working with "api-skeletons/oauth2-doctrine" version 5.1.0 in my project which requires "laminas-api-tools/api-tools-oauth2": "^1.4" which requires "bshaffer/oauth2-server-php": "^1.12.1".

The DoctrineAdapter implements the "OAuth2\OpenID\Storage\AuthorizationCodeInterface as OpenIDAuthorizationCodeInterface".

After my last composer update I discovered the following issue:
The recent change in "OAuth2\OpenID\Storage\AuthorizationCodeInterface" leads to an error because the "setAuthorizationCode" function in the DoctrineAdapter is not compatible with this AuthorizationCodeInterface anymore:

Declaration of ApiSkeletons\OAuth2\Doctrine\Adapter\DoctrineAdapter::setAuthorizationCode($code, $client_id, $user_id, $redirect_uri, $expires, $scope = null, $id_token = null) must be compatible with OAuth2\OpenID\Storage\AuthorizationCodeInterface::setAuthorizationCode($code, $client_id, $user_id, $redirect_uri, $expires, $scope = null, $id_token = null, $code_challenge = null, $code_challenge_method = null)

These changes were made 3 weeks ago in version 1.14.0: https://github.com/bshaffer/oauth2-server-php/blob/v1.14.0/src/OAuth2/OpenID/Storage/AuthorizationCodeInterface.php

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions