You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CONTRIBUTING.md is a short overview (bug/feature/PR bullets, design philosophy, CI mention). Skillware's contributing guide is the single entry point: contribution-type table, fork/upstream sync commands, universal expectations (scope, changelog, tests), PR process, and links to testing + agent workflow + PR template.
Rooms has no .github/PULL_REQUEST_TEMPLATE.md. Reviewers repeat the same asks (tests, changelog, rebase, git email). New contributors (including agents) lack a checklist aligned with our labels (session-logic, cli, testing, etc.).
Proposed Solution
Rewrite CONTRIBUTING.md with Skillware-inspired sections (adapted for Rooms — no skill registry):
Navigation table
Ways to contribute table: core framework (rooms/), CLI wizard (cli.py / rooms/cli.py), settings YAML, docs, tests, good first issue
Universal expectations: scope discipline, match existing style, when to update CHANGELOG, git author email must be GitHub-verified (see Feat preflight check #43 contributor attribution lesson)
Pull request process: link issue, local verify commands, push to fork, CI green
Problem Statement
CONTRIBUTING.mdis a short overview (bug/feature/PR bullets, design philosophy, CI mention). Skillware's contributing guide is the single entry point: contribution-type table, fork/upstream sync commands, universal expectations (scope, changelog, tests), PR process, and links to testing + agent workflow + PR template.Rooms has no
.github/PULL_REQUEST_TEMPLATE.md. Reviewers repeat the same asks (tests, changelog, rebase, git email). New contributors (including agents) lack a checklist aligned with our labels (session-logic,cli,testing, etc.).Proposed Solution
Rewrite
CONTRIBUTING.mdwith Skillware-inspired sections (adapted for Rooms — no skill registry):rooms/), CLI wizard (cli.py/rooms/cli.py), settings YAML, docs, tests, good first issuefeat/issue-N-short-descAdd
.github/PULL_REQUEST_TEMPLATE.mdwith:Fixes #N)Cross-link from README Documentation Library.
Acceptance criteria
CONTRIBUTING.mdcovers fork workflow, test commands, changelog policy, git email noteAlternatives Considered
Priority
Medium 🟡
Additional Context
Skillware refs:
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md.Can be split across two PRs (docs first, template second) but one issue is fine.