From 6519cdccdf1067a6b02131f2dcc6eed0c6b201f1 Mon Sep 17 00:00:00 2001 From: Rafael Ramos Date: Mon, 8 Nov 2021 21:08:06 +0100 Subject: [PATCH] Update InvokeFunctionHandler.java Analysis of this package determined that this line of code might contain a resource leak. A resource leak can slow down or crash your system. --- .../invoke/handler/InvokeFunctionHandler.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/aws-toolkit-eclipse-master/bundles/com.amazonaws.eclipse.lambda/src/com/amazonaws/eclipse/lambda/invoke/handler/InvokeFunctionHandler.java b/aws-toolkit-eclipse-master/bundles/com.amazonaws.eclipse.lambda/src/com/amazonaws/eclipse/lambda/invoke/handler/InvokeFunctionHandler.java index 50ed6e851..57fa1ab11 100644 --- a/aws-toolkit-eclipse-master/bundles/com.amazonaws.eclipse.lambda/src/com/amazonaws/eclipse/lambda/invoke/handler/InvokeFunctionHandler.java +++ b/aws-toolkit-eclipse-master/bundles/com.amazonaws.eclipse.lambda/src/com/amazonaws/eclipse/lambda/invoke/handler/InvokeFunctionHandler.java @@ -279,17 +279,18 @@ private static InvokeResult invokeFunction(AWSLambda lambda, String input, } private static void askForDeploymentFirst(IJavaElement selectedJavaElement) { - MessageDialog dialog = new MessageDialog( + try (MessageDialog dialog = new MessageDialog( Display.getCurrent().getActiveShell(), "Function not uploaded yet", null, "You need to upload the function to Lambda before invoking it.", MessageDialog.INFORMATION, - new String[] { "Upload now", "Cancel"}, 0); - int result = dialog.open(); + new String[] { "Upload now", "Cancel"}, 0)) { + int result = dialog.open(); - if (result == 0) { - LambdaAnalytics.trackUploadWizardOpenedBeforeFunctionInvoke(); - UploadFunctionToLambdaCommandHandler.doUploadFunctionProjectToLambda(selectedJavaElement); + if (result == 0) { + LambdaAnalytics.trackUploadWizardOpenedBeforeFunctionInvoke(); + UploadFunctionToLambdaCommandHandler.doUploadFunctionProjectToLambda(selectedJavaElement); + } } }