fix: resolve workflow issues causing infinite empty PR loop

- Fix JSON parsing in ai-website-guardian.yml (downloads task)
  to properly quote JS object property names before parsing as JSON
- Fix malformed bash redirects 2>gh pr merge ... 2>&11 in
  pr-auto-review.yml and audit-all-pages.yml
- Disable auto-merge for empty PRs in both pr-auto-review.yml
  and audit-all-pages.yml to break the infinite loop
- Add local HTTP server step to lighthouse.yml before running
  Lighthouse CI
- Add missing alt attribute to logo img in build.html

Author: spivanatalie64

.github/workflows/ai-website-guardian.yml

@@ -140,13 +140,16 @@ jobs:
             exit(1)
 
           js_text = editions_match.group(1)
-          # Convert JS object syntax to valid JSON (single quotes → double quotes)
+          # Convert JS object syntax to valid JSON
+          # 1. Quote unquoted property names
+          js_text = re.sub(r'([{,]\s*)([a-zA-Z_][a-zA-Z0-9_]*)\s*:', r'\1"\2":', js_text)
+          # 2. Replace single quotes with double quotes (for string values)
+          # Use a simple heuristic: replace ' with " outside of already-quoted strings
           js_text = re.sub(r"'", '"', js_text)
-          # Convert boolean values
-          js_text = re.sub(r':\s*true', ': true', js_text)
-          js_text = re.sub(r':\s*false', ': false', js_text)
-          # Remove trailing commas before ] and }
+          # 3. Remove trailing commas before ] and }
           js_text = re.sub(r',\s*([\]}])', r'\1', js_text)
+          # 4. Fix any double-quoted strings that got extra quotes
+          js_text = re.sub(r'""', '"', js_text)
           editions = json.loads(js_text)
           issues = []
 

.github/workflows/audit-all-pages.yml

@@ -427,8 +427,14 @@ except: print('APPROVE')
                 
                 echo "AI Review: $REVIEW"
                 if echo "$REVIEW" | grep -qi "APPROVE"; then
-                  gh pr merge "$PR_NUMBER" --merge --auto --delete-branch 2>gh pr merge "$PR_NUMBER" --merge --auto 2>&11 || true
-                  echo "✅ PR auto-merged"
+                  # Only auto-merge if PR has actual changes
+                  PR_FILES=$(gh pr view "$PR_NUMBER" --json files --jq '.files | length' 2>/dev/null || echo "0")
+                  if [ "$PR_FILES" -gt 0 ]; then
+                    gh pr merge "$PR_NUMBER" --merge --auto --delete-branch 2>/dev/null || true
+                    echo "✅ PR auto-merged"
+                  else
+                    echo "⏸ PR approved but not auto-merged (no file changes)"
+                  fi
                 else
                   echo "⏸ PR needs manual review"
                 fi

.github/workflows/lighthouse.yml

@@ -17,6 +17,10 @@ jobs:
       - name: Install Lighthouse CI
         run: |
           npm install -g @lhci/cli@0.12.x
+      - name: Start local server
+        run: |
+          python3 -m http.server 8080 &
+          sleep 2
       - name: Run Lighthouse CI
         run: |
-          lhci autorun --collect.staticDistDir=. --collect.url=http://localhost:8080/index.html --collect.url=http://localhost:8080/blog.html --collect.url=http://localhost:8080/git-tracker.html --upload.target=temporary-public-storage
+          lhci autorun --collect.url=http://localhost:8080/index.html --collect.url=http://localhost:8080/blog.html --collect.url=http://localhost:8080/git-tracker.html --upload.target=temporary-public-storage

.github/workflows/pr-auto-review.yml

@@ -65,10 +65,9 @@ jobs:
 
           DIFF=$(cat /tmp/pr-diff.txt 2>/dev/null)
           if [ -z "$DIFF" ]; then
-            echo "Empty diff — auto-approving"
-            gh pr review "$PR_NUM" --approve \
-              --body "_🤖 AI Review (${AI_MODEL})_\n\n**Verdict:** ✅ APPROVE\n**Reason:** No code changes detected (empty diff)." 2>/dev/null || true
-            gh pr merge "$PR_NUM" --merge --auto --delete-branch 2>gh pr merge "$PR_NUM" --merge --auto 2>&11 || true
+            echo "Empty diff — skipping auto-merge"
+            gh pr review "$PR_NUM" --comment \
+              --body "_🤖 AI Review (${AI_MODEL})_\n\n**Verdict:** ⏸ SKIP\n**Reason:** No code changes detected (empty diff). Auto-merge disabled for empty PRs." 2>/dev/null || true
             exit 0
           fi
 
@@ -161,8 +160,13 @@ PYEOF
           if [ "$VERDICT" = "APPROVE" ]; then
             gh pr review "$PR_NUM" --approve --body "$(echo -e "$COMMENT")" 2>/dev/null || true
             echo "✅ PR approved by AI"
-            # Auto-merge
-            gh pr merge "$PR_NUM" --merge --auto --delete-branch 2>gh pr merge "$PR_NUM" --merge --auto 2>&11 || true
+            # Auto-merge only if PR has actual changes
+            PR_FILES=$(gh pr view "$PR_NUM" --json files --jq '.files | length' 2>/dev/null || echo "0")
+            if [ "$PR_FILES" -gt 0 ]; then
+              gh pr merge "$PR_NUM" --merge --auto --delete-branch 2>/dev/null || true
+            else
+              echo "⏸ PR approved but not auto-merged (no file changes)"
+            fi
           elif [ "$VERDICT" = "REJECT" ]; then
             gh pr review "$PR_NUM" --request-changes --body "$(echo -e "$COMMENT")" 2>/dev/null || true
             echo "❌ PR rejected by AI"

build.html

@@ -70,7 +70,7 @@
 .page-footer a{color:var(--acreetion-green);text-decoration:none}
 #log-area{background:var(--acreetion-panel-bg);border:1px solid var(--acreetion-box-border);padding:1rem;font-family:var(--font-mono);font-size:0.85rem;color:var(--acreetion-text);max-height:300px;overflow-y:auto;margin-top:0.5rem;display:none;white-space:pre-wrap}
 </style></head><body>
-<header class="page-header"><div class="header-content"><a href="index.html" class="logo"><img src="acreetionoslogo.webp" loading="lazy" class="logo-img" width="40" height="40" decoding="auto" loading="eager" fetchpriority="high"><span class="logo-text">Acreetion<span>OS</span></span></a><nav class="main-nav"><a href="index.html">Home</a><a href="flash.html">Downloads</a><a href="build.html" class="btn btn-storm">ISO Builder</a><a href="unofficial.html" class="btn btn-storm" style="background-color:var(--acreetion-purple);color:#fff">Unofficial</a><a href="https://github.com/acreetionos-code/" class="btn btn-storm" style="background-color:#333">GitHub</a></nav></div></header>
+<header class="page-header"><div class="header-content"><a href="index.html" class="logo"><img src="acreetionoslogo.webp" alt="AcreetionOS Logo" loading="lazy" class="logo-img" width="40" height="40" decoding="auto" loading="eager" fetchpriority="high"><span class="logo-text">Acreetion<span>OS</span></span></a><nav class="main-nav"><a href="index.html">Home</a><a href="flash.html">Downloads</a><a href="build.html" class="btn btn-storm">ISO Builder</a><a href="unofficial.html" class="btn btn-storm" style="background-color:var(--acreetion-purple);color:#fff">Unofficial</a><a href="https://github.com/acreetionos-code/" class="btn btn-storm" style="background-color:#333">GitHub</a></nav></div></header>
 
 <div class="content-box"><div class="box-header"><h2><i class="bi bi-gear-wide-connected"></i> AcreetionOS ISO Builder</h2></div><div class="box-body">
 <p style="margin-bottom:1rem;color:var(--acreetion-text)">Select an edition below and trigger an automated build. The ISO will be compiled in our GitHub Actions pipeline and uploaded to Cloudflare R2. You can watch the build progress in real-time.</p>