Feature/json export#10
Open
brentspector wants to merge 4 commits into
Open
Conversation
AdAstra-LD
force-pushed
the
main
branch
3 times, most recently
from
7cdf44b to
6b95302
Compare
AdAstra-LD
force-pushed
the
main
branch
4 times, most recently
from
375ce49 to
475d034
Compare
AdAstra-LD
force-pushed
the
main
branch
4 times, most recently
from
195a610 to
3857301
Compare
AdAstra-LD
force-pushed
the
main
branch
6 times, most recently
from
d7592fd to
89f6a47
Compare
AdAstra-LD
force-pushed
the
main
branch
2 times, most recently
from
0c8e429 to
66942c3
Compare
AdAstra-LD
force-pushed
the
main
branch
2 times, most recently
from
27f3602 to
b183112
Compare
AdAstra-LD
force-pushed
the
main
branch
3 times, most recently
from
aa39e95 to
8f8face
Compare
AdAstra-LD
force-pushed
the
main
branch
3 times, most recently
from
b7d7b7f to
f925ab9
Compare
AdAstra-LD
force-pushed
the
main
branch
2 times, most recently
from
52e7dfe to
9b21048
Compare
AdAstra-LD
force-pushed
the
main
branch
2 times, most recently
from
6283d52 to
f95ab36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This remakes the Trainer Import and Export feature to export to JSON rather than binary. Additionally, it allows the entire list of trainers to be exported or imported as JSON, rather than just a single trainer.
The UI was a bit tricky to manipulate, so I would be fine with it being redone, so long as this functionality exists.