Move UpdateUpgradeIcon to ItemButton

Move UpdateUpgradeIcon to ItemButton.lua
Call UpdateUpgradeIcon in the OnEnabled in core.lua for handling profile changing
Set the Setter function on the option group that is inherited by the Anchor and Offset options instead of using a setter for each option.
Fix Whitespaces

Remove the whitespace in Options.lua to minimize changes with the master branch
Add a whitespace in Core.lua to minimize changes with the master branch
Fix whitespaces

Fix whitespaces
 ../core/Core.lua:174
../config/Options.lua:668
Actually fix whitespaces this time

perhaps it is time I installed a linter...

Author: legowxelab2z8

config/Options.lua

@@ -269,25 +269,6 @@ local function GetOptions()
 			bagList[module.bagName] = L[module.bagName]
 		end
 	end
-
-	local function UpdateUpgradeIcon()
-		local db = addon.db.profile
-		for button, _ in addon:GetPool("ItemButton"):IterateActiveObjects() do
-			button.UpgradeIcon:ClearAllPoints()
-			button.UpgradeIcon:SetPoint(db.upgradeIconAnchor, button, db.upgradeIconOffsetX, db.upgradeIconOffsetY)
-		end
-		for button, _ in addon:GetPool("BankItemButton"):IterateActiveObjects() do
-			button.UpgradeIcon:ClearAllPoints()
-			button.UpgradeIcon:SetPoint(db.upgradeIconAnchor, button, db.upgradeIconOffsetX, db.upgradeIconOffsetY)
-		end
-	end
-
-	local function SetOptionAndUpdateUpgradeIcon(info, value, ...)
-		local db = addon.db.profile
-		db[info[#info]] = value
-		UpdateUpgradeIcon()
-	end
-
 	options = {
 		--@debug@
 		name = addonName..' DEV',
@@ -665,6 +646,11 @@ local function GetOptions()
 						type = 'group',
 						inline = true,
 						order = 400,
+						set = function(info, value, ...)
+								local db = addon.db.profile
+								db[info[#info]] = value
+								addon:UpdateUpgradeIcon()
+								end,
 						args = {
 							upgradeIconAnchor = {
 								name = L['Anchor'],
@@ -679,7 +665,6 @@ local function GetOptions()
 									BOTTOMLEFT = L['Bottom Left'],
 									BOTTOM = L['Bottom'],
 									BOTTOMRIGHT = L['Bottom Right'],
-									
 								},
 								sorting = {
 									[1] = "TOPLEFT",
@@ -693,7 +678,6 @@ local function GetOptions()
 									[9] = "BOTTOMRIGHT",
 								},
 								order = 10,
-								set = SetOptionAndUpdateUpgradeIcon,
 							},
 							upgradeIconOffsetX = {
 								name = L["X Offset"],
@@ -704,7 +688,6 @@ local function GetOptions()
 								step = 1,
 								bigStep = 1,
 								order = 20,
-								set = SetOptionAndUpdateUpgradeIcon,
 							},
 							upgradeIconOffsetY = {
 								name = L["Y Offset"] ,
@@ -715,7 +698,6 @@ local function GetOptions()
 								step = 1,
 								bigStep = 1,
 								order = 30,
-								set = SetOptionAndUpdateUpgradeIcon,
 							},
 						},
 					},

core/Core.lua

@@ -170,6 +170,7 @@ function addon:OnEnable()
 	self.bagFont:ApplySettings()
 	self.sectionFont:ApplySettings()
 	self:UpdatePositionMode()
+	self:UpdateUpgradeIcon()
 
 	self:Debug('Enabled')
 end

widgets/ItemButton.lua

@@ -176,6 +176,18 @@ hooksecurefunc(addon, 'OnInitialize', function()
 	containerButtonPool:PreSpawn(160)
 end)
 
+function addon:UpdateUpgradeIcon()
+	local db = addon.db.profile
+	for button, _ in addon:GetPool("ItemButton"):IterateActiveObjects() do
+		button.UpgradeIcon:ClearAllPoints()
+		button.UpgradeIcon:SetPoint(db.upgradeIconAnchor, button, db.upgradeIconOffsetX, db.upgradeIconOffsetY)
+	end
+	for button, _ in addon:GetPool("BankItemButton"):IterateActiveObjects() do
+		button.UpgradeIcon:ClearAllPoints()
+		button.UpgradeIcon:SetPoint(db.upgradeIconAnchor, button, db.upgradeIconOffsetX, db.upgradeIconOffsetY)
+	end
+end
+
 --------------------------------------------------------------------------------
 -- Model data
 --------------------------------------------------------------------------------