Macro spells don't work, GetActionInfo changed in Patch 10.2

[Nulgar]

Version (*):

10.0.3

Bug description (*):

I noticed that my macros with spells didn't show ABA overlays anymore in Patch 10.2, neither with addon version 10.0.3 nor the 10.0.0 I had installed before. "Spells & items" view said the buttons were "unsupported".

I recalled seeing a mention that macros with items broke a while ago, so I did some digging in the code, and found that GetActionInfo no longer returns the macro index as the actionId even for spells.

For spells, the function pleasantly returns "macro", [spellID], "spell" so that's an easy fix, although no luck for macro conditionals without the index.
For items, the actionId is just slot-1 which I guess is unchanged.

[Rainrider]

GetActionInfo is strange now. For spells it returns the spell id as its second return, as you mentioned, after resolving macro conditions.

For items, it returns some strange indecies now:

#showtooltip
/use 14

returns "macro", 59, "item" (action id is 60)

#showtooltip
/use 13

returns "macro", 5, "" (trinket does not have an on use spell here) (action id is 59)

#showtooltip
/use Hearthstone

returns "macro", 66, "item" (action id is 67)

If I swap trinket positions, the returns from GetActionInfo change as follows:

• "macro", 3, "" (action id is 60)
• "macro", 58, "item" (action id is 59)

The macro could be resolved by querying by name:

local name, texture, body = GetMacroInfo(GetActionText(actionId))

however macro names are not guaranteed to be unique so this might return wrong results.

Could you pull latest master and see if this is resolved now? Also, please tell what actions bars addon you are using as this might be relevant (Dominos and stock ui should work, not 100% sure about LibActionButton based ones)

[mbattersby]

FWIW this is logged here - Stanzilla/WoWUIBugs#495

[Nulgar]

Ah, sorry, did not notice there were replies.

Yes, it seems to work fine again, thank you!
I'm not using macros with duplicate or empty names, so I won't run into issues there.