fix: no empty searches, product boxes jumpiness, and lag between product checks#643
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-06-02T21:28:58.857Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-06-03T16:27:18.694Z |
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-06-03T16:44:34.507Z |
|
❌ Test ResultsStatus: Some tests failed! 🔍 Click to view failed testsTest Coverage ReportOverall Coverage Summary
Coverage by File/Directory
Coverage report generated at 2026-06-03T16:54:47.575Z |
timkim
approved these changes
Jun 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/DEVSITE-2425
Test URL: https://new-devsite-2425--adp-devsite-stage--adobedocs.aem.page/test/diane/devsite-1471-search-ui?products=all&query=AI
Things to test: search with an empty query, click around the products, and test a link with a fragment.
Issue: empty search on initialization
Fix: Wrapped the search client so empty queries return local empty results instead of hitting Algolia
Source: https://www.algolia.com/doc/guides/building-search-ui/going-further/conditional-requests/js
Issue: Product checkbox jumpiness
Fix: Removed logic that hid/showed product checkboxes based on which products had hits
Issue: lag in between clicking products and All Products
Fix: On each product filter change, removes previously added dynamic widgets before adding new ones and one time static widgets are registered once to avoid duplicates and extra work
Issue: anchor links weren't added to URLs
Fix: Some results have a "fragment" which is the anchor link so when it exists it will get added to the URL to direct the user to the correct place in the page