From 61116129c9d600a8e0672d57854123b3bde174f5 Mon Sep 17 00:00:00 2001 From: agentrelaybot Date: Fri, 18 Sep 2026 08:25:58 -0700 Subject: [PATCH] chore(ci): park the review swarm until it is a RelayFlow v2 flow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `review` check failed on every open PR (#451, #455, #441) in the swarm's own posting step, not on a code verdict: Fetching patch for run ... No changes to sync — the workflow did not modify any files. ##[error]Process completed with exit code 1 Reproducible across reruns with fresh swarm ids. A check that fails on every PR can neither approve nor block, so it was merged over in practice; leaving it on `pull_request` only taught people to ignore a red check. That failure is the v1 design showing through: the gate assumes a review's product is a patch to sync back, so a review that correctly proposes no code change reads as a failure. It also drives RelayFlow v1 via `agent-relay cloud run`, the surface relay#1783 deprecated. Both point at the v2 port in #470 rather than a repair here. `workflow_dispatch` is a parking trigger, not a working manual path — every step reads `github.event.pull_request.*`. Wiring that up is deliberately left undone; it is work on the surface #470 retires. The wrapper guard stays on `pull_request_target` and keeps passing, so a candidate still cannot weaken the gate that will judge it once it returns. Co-Authored-By: Claude Opus 5 (1M context) Session-Id: d458bd97-53d8-4f02-be9c-48b67b93c916 --- .github/workflows/review-swarm.yml | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/.github/workflows/review-swarm.yml b/.github/workflows/review-swarm.yml index d5655263f..528d4504e 100644 --- a/.github/workflows/review-swarm.yml +++ b/.github/workflows/review-swarm.yml @@ -1,8 +1,26 @@ name: Review swarm +# PARKED. Does not run. Port tracked in AgentWorkforce/flows#470. +# +# This failed on every open PR (#451, #455, #441) in its own posting step -- +# "No changes to sync -- the workflow did not modify any files" -- rather than +# on any code verdict. Reproducible across reruns with fresh swarm ids. A check +# that fails on every PR can neither approve nor block, so it was merged over +# in practice; leaving it on `pull_request` only trained people to ignore a red +# check. +# +# The failure is the v1 design showing through: this gate assumes a review's +# product is a patch to sync back, so a review that correctly proposes no code +# change reads as a failure. It also drives RelayFlow v1 (`agent-relay cloud +# run`), which relay#1783 deprecated. Both argue for the v2 port rather than a +# repair here. +# +# `workflow_dispatch` is the parking trigger, not a working manual path: every +# step below reads `github.event.pull_request.*`, which is empty off a +# `pull_request` event. Wiring that up is deliberately not done -- it is work +# spent on the surface #470 retires. on: - pull_request: - types: [opened, synchronize, reopened, ready_for_review] + workflow_dispatch: permissions: contents: read