[FEATURE] add the update byte for dualshock4 output report callback

[AhmedAmrNabil]

Is your feature request related to a problem? Please describe

from: https://controllers.fandom.com/wiki/Sony_DualShock_4#Output_Reports the output report struct of the ds4 have 1 byte containing 8 flags:
EnableRumbleUpdate : 1;
EnableLedUpdate : 1;
EnableLedBlink : 1;
EnableExtWrite : 1;
EnableVolumeLeftUpdate : 1;
EnableVolumeRightUpdate : 1;
EnableVolumeMicUpdate : 1;
EnableVolumeSpeakerUpdate : 1;

the first 3 bits are needed with the report as currently we have no idea if the game requested change only to the vibration or to the lightbar or both so we need this first byte in the output struct

Describe the solution you'd like

update the output stuct to be:

type OutputState struct {
	UpdateByte uint8 // flags for what to update
	RumbleSmall uint8 // (0-255)
	RumbleLarge uint8 // (0-255)
	LedRed      uint8 // (0-255)
	LedGreen    uint8 // (0-255)
	LedBlue     uint8 // (0-255)
	FlashOn     uint8 // (units of 2.5ms)
	FlashOff    uint8 // (units of 2.5ms)
}

and update the callbacks so the update byte get passed from the usbip to the this struct

[Ryochan7]

I was just going to make an issue about this. I wanted to use the newer SetDS4OutputCallback function and wondered if the report was being handled properly once I saw the function parameters. The code shows that the features byte is not being parsed. The features byte is absolutely necessary for some games that have native DualShock 4 support. The two biggest use cases for me are Streets of Rage 4 and The Witcher 3. It is the only way to tell if a game is requesting a lightbar update or a rumble update.

Crash out alert. There was so much drama surrounding this same problem with ViGEmBus that it caused me to rage quit developing DS4Windows the first time around. Users kept blaming me for incorrect rumble support for virtual DS4 and Nefarius decided to gaslight people and say it was all my fault. I disabled virtual DS4 rumble support and people got mad. I re-enabled support for it and people got mad. I think it was a problem for around two years until I found the bug in the ViGEmBus code and posted my findings on the ViGEmBus issue tracker.

[AhmedAmrNabil]

I disabled virtual DS4 rumble support and people got mad. I re-enabled support for it and people got mad.

Interesting, in PRAGMATA I have an issue with the vibration being infinite for some reason until I fire the rifle and it stops, I guess that's the issue, I am developing my own mapper right now and I am supporting multiple backend like viiper,vigem and HIDMaestro but didn't try playing it with the viiper backend yet, I will test it and update the comment later

[Ryochan7]

Got curious and Google found an old ViGEmBus issue I posted discussing my DS4 output report findings. I cannot find the original post I was thinking of as I remember using a George Costanza pic in the post.

[Request] Add features byte info for DS4_OUTPUT_REPORT in DS4_REQUEST_NOTIFICATION struct
nefarius/ViGEmBus#80