From e0f2e6c1d830e37debe726ace9a0d347c19bb54e Mon Sep 17 00:00:00 2001 From: luigiazoreng Date: Tue, 30 Dec 2025 16:07:39 -0300 Subject: [PATCH 1/6] Removes SSH mount from dev container config Eliminates automatic binding of the local SSH directory into the development container for improved portability and to reduce potential security concerns. Retains all other configuration settings. --- .devcontainer/devcontainer.json | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 9d5aa02..a53dc2b 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,3 +1,4 @@ + { "name": "Frappe Bench", "forwardPorts": [8000, 9000, 6787], @@ -25,8 +26,5 @@ "dockerComposeFile": "./docker-compose.yml", "service": "frappe", "workspaceFolder": "/workspace/development", - "shutdownAction": "stopCompose", - "mounts": [ - "source=${localEnv:USERPROFILE}/.ssh,target=/home/frappe/.ssh,type=bind,consistency=cached" - ] + "shutdownAction": "stopCompose" } \ No newline at end of file From f61d22e6ffa54550f25fe76196b288df41fd668c Mon Sep 17 00:00:00 2001 From: luigiazoreng Date: Tue, 30 Dec 2025 17:17:00 -0300 Subject: [PATCH 2/6] Specifies Python 3.11 for bench initialization Ensures bench setup uses Python 3.11 for improved compatibility and consistency across environments. --- development/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development/build.sh b/development/build.sh index ede54d7..e1f871e 100644 --- a/development/build.sh +++ b/development/build.sh @@ -98,7 +98,7 @@ BENCH_DIR="$DEV_DIR/frappe-bench" if [ ! -d "$BENCH_DIR" ]; then echo "Starting bench setup..." - CMD_BENCH_SETUP="bench init --skip-redis-config-generation frappe-bench" + CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python /usr/bin/python3.11 frappe-bench" if [ "$USE_BENCH_V15" == "y" ] || [ "$USE_BENCH_V15" == "Y" ]; then echo "Using Frappe-bench v15" CMD_BENCH_SETUP+=" --frappe-branch version-15" From 5c0ea9c8ae7e93a01156ca762def38c56558e33b Mon Sep 17 00:00:00 2001 From: luigiazoreng Date: Wed, 31 Dec 2025 13:30:45 +0000 Subject: [PATCH 3/6] feat: update VSCode settings for enhanced Git repository management --- development/.vscode/settings.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/development/.vscode/settings.json b/development/.vscode/settings.json index 38b6deb..9c26018 100644 --- a/development/.vscode/settings.json +++ b/development/.vscode/settings.json @@ -4,5 +4,12 @@ "editor.defaultFormatter": "ms-python.python", "editor.formatOnSave": true }, - "python.formatting.blackPath": "${workspaceFolder}/frappe-bench/env/bin/black" + "python.formatting.blackPath": "${workspaceFolder}/frappe-bench/env/bin/black", + "git.autoRepositoryDetection": true, + "git.detectSubmodules": true, + "git.detectSubmodulesLimit": 20, + "git.repositoryScanMaxDepth": 3, + "git.scanRepositories": [ + "${workspaceFolder}/frappe-bench/apps" + ] } \ No newline at end of file From b59c4d2378a6767ed6ba37f54ca892f821ca94ca Mon Sep 17 00:00:00 2001 From: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com> Date: Wed, 31 Dec 2025 11:03:08 -0300 Subject: [PATCH 4/6] Update .devcontainer/devcontainer.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com> --- .devcontainer/devcontainer.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index a53dc2b..174a6bd 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,4 +1,3 @@ - { "name": "Frappe Bench", "forwardPorts": [8000, 9000, 6787], From b040d7ffc1f4e06ae71c0680cf76668f73f6512f Mon Sep 17 00:00:00 2001 From: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com> Date: Wed, 31 Dec 2025 11:03:32 -0300 Subject: [PATCH 5/6] Update development/build.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com> --- development/build.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/development/build.sh b/development/build.sh index e1f871e..3c6a6dd 100644 --- a/development/build.sh +++ b/development/build.sh @@ -98,7 +98,13 @@ BENCH_DIR="$DEV_DIR/frappe-bench" if [ ! -d "$BENCH_DIR" ]; then echo "Starting bench setup..." - CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python /usr/bin/python3.11 frappe-bench" + # Determine which Python interpreter to use (prefer python3.11 if available) + if command -v python3.11 >/dev/null 2>&1; then + PYTHON_BIN="python3.11" + else + PYTHON_BIN="python3" + fi + CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python \"$PYTHON_BIN\" frappe-bench" if [ "$USE_BENCH_V15" == "y" ] || [ "$USE_BENCH_V15" == "Y" ]; then echo "Using Frappe-bench v15" CMD_BENCH_SETUP+=" --frappe-branch version-15" From d8612c6c50c2bb27ad57449e278fae76181fa404 Mon Sep 17 00:00:00 2001 From: luigiazoreng Date: Wed, 31 Dec 2025 15:23:59 +0000 Subject: [PATCH 6/6] fix: remove quotes around PYTHON_BIN in bench setup command --- development/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development/build.sh b/development/build.sh index 3c6a6dd..5a0232d 100644 --- a/development/build.sh +++ b/development/build.sh @@ -104,7 +104,7 @@ if [ ! -d "$BENCH_DIR" ]; then else PYTHON_BIN="python3" fi - CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python \"$PYTHON_BIN\" frappe-bench" + CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python $PYTHON_BIN frappe-bench" if [ "$USE_BENCH_V15" == "y" ] || [ "$USE_BENCH_V15" == "Y" ]; then echo "Using Frappe-bench v15" CMD_BENCH_SETUP+=" --frappe-branch version-15"