Skip to content

Melhorar a atualização do campo 'sector_applicant' para evitar marcação desnecessária do formulário como não salvo #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mxrcog wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Melhorar a atualização do campo 'sector_applicant' para evitar marcação desnecessária do formulário como não salvo #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cae197
Corrigir caminho do arquivo TypeScript no doctype IT Request
mxrcog Dec 30, 2025
1541630
Melhorar a atualização do campo 'sector_applicant' para evitar marcaç…
mxrcog Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions frappe_it_request/frappe_it_request/doctype/it_request/it_request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// For license information, please see license.txt
"use strict";
(() => {
// doctype/it_request/ts/it_request.ts
// frappe_it_request/doctype/it_request/ts/it_request.ts
var categories = {
"System": {
"Movidesk": [
Expand Down Expand Up @@ -213,11 +213,15 @@
try {
const r = await frappe.db.get_value("User", frm.doc["applicant"], "internal_department");
if (r && r.message && r.message.internal_department) {
frm.set_value("sector_applicant", r.message.internal_department);
frm.refresh_field("sector_applicant");
if (frm.doc["sector_applicant"] !== r.message.internal_department) {
frm.set_value("sector_applicant", r.message.internal_department);
frm.refresh_field("sector_applicant");
}
} else {
frm.set_value("sector_applicant", null);
frm.refresh_field("sector_applicant");
if (frm.doc["sector_applicant"]) {
frm.set_value("sector_applicant", null);
frm.refresh_field("sector_applicant");
}
}
} catch (error) {
console.error("Error fetching applicant's sector:", error);
Expand Down
16 changes: 11 additions & 5 deletions frappe_it_request/frappe_it_request/doctype/it_request/ts/it_request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,18 @@ async function initializeForm(frm: FrappeForm): Promise<void> {
try {
const r = await frappe.db.get_value('User', frm.doc['applicant'], 'internal_department');
if (r && r.message && r.message.internal_department) {
frm.set_value("sector_applicant", r.message.internal_department);
frm.refresh_field('sector_applicant');
// Only update the field if the value actually changed to avoid
// marking the form as dirty (which shows "Not Saved").
if (frm.doc['sector_applicant'] !== r.message.internal_department) {
frm.set_value("sector_applicant", r.message.internal_department);
frm.refresh_field('sector_applicant');
}
} else {
// Clear the field if no department is found
frm.set_value("sector_applicant", null);
frm.refresh_field('sector_applicant');
// Clear the field only if it currently has a value
if (frm.doc['sector_applicant']) {
frm.set_value("sector_applicant", null);
frm.refresh_field('sector_applicant');
}
}
} catch (error) {
console.error("Error fetching applicant's sector:", error);
Expand Down