yarn typecheck runs two projects and neither one covers scripts/ or the .ts files at the repository root:
tsconfig.backend.json — include: ["src/glue/**/*", "src/server/**/*"]tsconfig.renderer.json — include: ["src", "vitest.setup.ts"]
So scripts/seed.ts, scripts/mysql-seed.ts, forge.config.ts, vite.*.config.ts and vitest.config.ts get no type checking in CI at all. A type error in any of them passes every gate and is found by running the thing.
This came up three times in a row while working on #73, #105 and #107 — each PR notes it and declines to fix it, because a third of a fix in one branch conflicts with the other two.
What it needs
A third project (tsconfig.tooling.json) covering scripts/**/* and the root configs, added to the typecheck script. It will need its own compilerOptions — these files are Node-side and some are ESM config modules, so they do not fit either existing project's settings.
Expect real errors on the first run. scripts/seed.ts in particular has never been checked.
Do this after
PRs for #73, #105 and #107 all touch this area. Land those first.
yarn typecheckruns two projects and neither one coversscripts/or the.tsfiles at the repository root:tsconfig.backend.json—include: ["src/glue/**/*", "src/server/**/*"]tsconfig.renderer.json—include: ["src", "vitest.setup.ts"]So
scripts/seed.ts,scripts/mysql-seed.ts,forge.config.ts,vite.*.config.tsandvitest.config.tsget no type checking in CI at all. A type error in any of them passes every gate and is found by running the thing.This came up three times in a row while working on #73, #105 and #107 — each PR notes it and declines to fix it, because a third of a fix in one branch conflicts with the other two.
What it needs
A third project (
tsconfig.tooling.json) coveringscripts/**/*and the root configs, added to thetypecheckscript. It will need its owncompilerOptions— these files are Node-side and some are ESM config modules, so they do not fit either existing project's settings.Expect real errors on the first run.
scripts/seed.tsin particular has never been checked.Do this after
PRs for #73, #105 and #107 all touch this area. Land those first.