Skip to content

Commit efb60e7

Browse files
refactor: remove LogbookProvider and associated LogbookEntry model from dashboard to streamline codebase and improve maintainability
1 parent 09556da commit efb60e7

4 files changed

Lines changed: 6 additions & 148 deletions

File tree

dashboard/lib/main.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'package:flutter_local_notifications/flutter_local_notifications.dart';
33
import 'package:provider/provider.dart';
44
import 'package:sentracore_dashboard/providers/engine_provider.dart';
55
import 'package:sentracore_dashboard/providers/history_provider.dart';
6-
import 'package:sentracore_dashboard/providers/logbook_provider.dart';
76
import 'package:sentracore_dashboard/providers/settings_provider.dart';
87
import 'package:sentracore_dashboard/navigation/dashboard_navigation.dart';
98
import 'package:sentracore_dashboard/screens/dashboard_screen.dart';
@@ -48,9 +47,6 @@ class SentraCoreApp extends StatelessWidget {
4847
ChangeNotifierProvider<HistoryProvider>(
4948
create: (_) => HistoryProvider()..load(),
5049
),
51-
ChangeNotifierProvider<LogbookProvider>(
52-
create: (_) => LogbookProvider()..load(),
53-
),
5450
ChangeNotifierProvider(
5551
create: (ctx) => EngineProvider(
5652
settings: settings,

dashboard/lib/models/logbook_entry.dart

Lines changed: 0 additions & 52 deletions
This file was deleted.

dashboard/lib/providers/logbook_provider.dart

Lines changed: 0 additions & 90 deletions
This file was deleted.

dashboard/lib/widgets/responsive_builder.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,15 @@ class ResponsiveRowColumn extends StatelessWidget {
4141
}
4242
}
4343

44-
final row = Row(
44+
// Note: don't wrap LayoutBuilder output with IntrinsicHeight; Flutter
45+
// disallows intrinsic sizing for LayoutBuilder (see flutter.logs).
46+
//
47+
// We still stretch the Row so cards line up when their children use
48+
// Expanded/Flexible properly.
49+
return Row(
4550
crossAxisAlignment: CrossAxisAlignment.stretch,
4651
children: rowChildren,
4752
);
48-
return useIntrinsicHeight ? IntrinsicHeight(child: row) : row;
4953
} else {
5054
// Narrow: Stack vertically.
5155
// We need to strip out any `Expanded` or `Flexible` widgets since

0 commit comments

Comments
 (0)