ARE-01C: Improper Declarations of Abstract Functions
Description:
The AsRescuable::requestRescue and AsRescuable::rescue functions are meant to be virtual and implemented by derivative implementations, however, an empty declaration is present in both that would permit each to be invoked.
Example:
// to be overriden with the proper access control by inheriting contracts
function requestRescue(address _token) external virtual {}Recommendation:
We advise the functions to be declared without a code block ({}) to ensure they are overridden by derivative implementations.
Sate:
Aknowledged and fixed in 7513dea0fa835032548249c16d43db08f9247c55
ARE-01C: Improper Declarations of Abstract Functions
Description:
The
AsRescuable::requestRescueandAsRescuable::rescuefunctions are meant to bevirtualand implemented by derivative implementations, however, an empty declaration is present in both that would permit each to be invoked.Example:
Recommendation:
We advise the functions to be declared without a code block (
{}) to ensure they are overridden by derivative implementations.Sate:
Aknowledged and fixed in 7513dea0fa835032548249c16d43db08f9247c55