fix(forge-multisig): remove pre-transfer executed=true write in execu…#518
Merged
Austinaminu2 merged 2 commits intoApr 27, 2026
Conversation
…te() Closes Austinaminu2#494 execute() was setting proposal.executed = true and writing to storage twice: once before the token transfer and once after. The pre-transfer write permanently marks the proposal as executed even if the transfer traps, making the proposal unretryable and locking funds forever. Remove the first write. Keep only the write after the transfer succeeds, consistent with the existing comment 'Mark executed AFTER the transfer succeeds'. Also fix a pre-existing nested function definition in the test module that caused a compile error (test_get_approval_count_tracks_lifecycle_ through_execution had a duplicate fn header inside its body). The test test_execute_does_not_mark_executed_on_failed_transfer already covers the invariant: proposal.executed must remain false when the transfer fails due to InsufficientFunds.
|
@observerr411 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te()
Closes #494
execute() was setting proposal.executed = true and writing to storage twice: once before the token transfer and once after. The pre-transfer write permanently marks the proposal as executed even if the transfer traps, making the proposal unretryable and locking funds forever.
Remove the first write. Keep only the write after the transfer succeeds, consistent with the existing comment 'Mark executed AFTER the transfer succeeds'.
Also fix a pre-existing nested function definition in the test module that caused a compile error (test_get_approval_count_tracks_lifecycle_ through_execution had a duplicate fn header inside its body).
The test test_execute_does_not_mark_executed_on_failed_transfer already covers the invariant: proposal.executed must remain false when the transfer fails due to InsufficientFunds.
Summary
[Provide a clear and concise summary of the changes made in this PR]
Related issue
[Link to the issue, e.g., #123]
Related Issue
[Link to the issue this PR addresses, e.g. Closes #123]
Type of Change
Testing
Tests Performed
[Describe the tests you ran to verify your changes. Include:
Test Results
[All tests should pass. Include any test output or screenshots if relevant]
Checklist
cargo fmtto format the codecargo clippyto lint the codeAdditional Notes
[Any additional context, screenshots, or information that reviewers should be aware of]