From a415e17cc9cc0b1cf00389288c80b9c66a957ae8 Mon Sep 17 00:00:00 2001 From: "sonarqube-agent[bot]" <210722872+sonarqube-agent[bot]@users.noreply.github.com> Date: Mon, 25 May 2026 01:03:56 +0000 Subject: [PATCH] fix: Address 5 SonarQube issues Fixed issues: - AZ42DBWCwWSCt-IKizvE for python:S1481 rule - AZ42DBCTwWSCt-IKizcd for python:S5713 rule - AZ42DBCTwWSCt-IKizce for python:S5713 rule - AZ42DBCTwWSCt-IKizch for python:S5713 rule - AZ42DBCTwWSCt-IKizci for python:S5713 rule Generated by SonarQube Agent (task: 76ba5c30-ea51-44ee-8354-f119d223d03b) --- scripts/notebook_validator.py | 6 +----- unsloth/models/rl_replacements.py | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/scripts/notebook_validator.py b/scripts/notebook_validator.py index 0e7a54129ad..46b956f274d 100644 --- a/scripts/notebook_validator.py +++ b/scripts/notebook_validator.py @@ -878,11 +878,7 @@ def cmd_drift(args: argparse.Namespace) -> int: print(f"FAIL: {update_script} not found", file = sys.stderr) return 2 # Stash any pre-existing dirty state, run the updater, diff, restore. - head = ( - subprocess.check_output(["git", "rev-parse", "HEAD"], cwd = nbdir) - .decode() - .strip() - ) + subprocess.check_output(["git", "rev-parse", "HEAD"], cwd = nbdir) subprocess.run( ["git", "-C", str(nbdir), "stash", "--include-untracked"], check = False, diff --git a/unsloth/models/rl_replacements.py b/unsloth/models/rl_replacements.py index 6c70a5cc7ca..c066b4174ae 100644 --- a/unsloth/models/rl_replacements.py +++ b/unsloth/models/rl_replacements.py @@ -1871,7 +1871,7 @@ def openenv_vllm_reload_weights(): try: import trl.experimental.openenv.utils as openenv_utils import trl.experimental.openenv as openenv - except (ImportError, NameError, Exception) as e: + except Exception as e: logger.info(f"Unsloth: Failed to import trl openenv: {e}") logger.info( "Unsloth: trl.experimental.openenv not available — skipping RL openenv patches." @@ -1951,7 +1951,7 @@ def vllm_generation_init_patch(): try: import trl.generation.vllm_generation as vllm_generation - except (ImportError, NameError, Exception) as e: + except Exception as e: logger.info(f"Unsloth: Failed to import trl.generation.vllm_generation: {e}") return