From 2f1389ea5bfa75a3dcc4deeeaaa100114c113e8b Mon Sep 17 00:00:00 2001 From: "sonarqube-agent[bot]" <210722872+sonarqube-agent[bot]@users.noreply.github.com> Date: Mon, 1 Jun 2026 01:03:01 +0000 Subject: [PATCH] fix: Address 5 SonarQube issues Fixed issues: - AZ42DBWCwWSCt-IKizvH for python:S1481 rule - AZ42DBWCwWSCt-IKizvM for python:S5713 rule - AZ42DBWCwWSCt-IKizvJ for python:S5713 rule - AZ42DBWiwWSCt-IKizvy for python:S5713 rule - AZ42DBWiwWSCt-IKizvx for python:S5713 rule Generated by SonarQube Agent (task: c424cf74-6602-4c7f-a526-7a935e46d904) --- scripts/check_new_install_scripts.py | 2 +- scripts/notebook_validator.py | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/scripts/check_new_install_scripts.py b/scripts/check_new_install_scripts.py index af3c84f96d0..9f838112fe7 100644 --- a/scripts/check_new_install_scripts.py +++ b/scripts/check_new_install_scripts.py @@ -175,7 +175,7 @@ def _fetch_registry_scripts(name: str, version: str) -> dict[str, str] | None: try: with urllib.request.urlopen(url, timeout = REGISTRY_TIMEOUT_SECS) as resp: body = resp.read() - except (urllib.error.URLError, OSError, ValueError, TimeoutError): + except (OSError, ValueError): return None try: meta = json.loads(body) diff --git a/scripts/notebook_validator.py b/scripts/notebook_validator.py index 0e7a54129ad..28aed5f42af 100644 --- a/scripts/notebook_validator.py +++ b/scripts/notebook_validator.py @@ -1083,11 +1083,6 @@ def cmd_api(args: argparse.Namespace) -> int: surface = json.loads(surface_path.read_text()) converted = pathlib.Path(args.converted_dir).resolve() findings: list[Finding] = [] - fast_models = ( - set(surface.get("FastVisionModel", [])) - | set(surface.get("FastLanguageModel", [])) - | set(surface.get("FastModel", [])) - ) for py in sorted(converted.glob("*.py")): try: tree = ast.parse(py.read_text(encoding = "utf-8")) @@ -1143,7 +1138,7 @@ def cmd_refresh_colab(args: argparse.Namespace) -> int: try: with urllib.request.urlopen(COLAB_PIP_FREEZE_URL, timeout = 15) as r: data = r.read() - except (urllib.error.URLError, urllib.error.HTTPError, TimeoutError) as e: + except (urllib.error.URLError, TimeoutError) as e: print(f"FAIL: could not fetch {COLAB_PIP_FREEZE_URL}: {e}", file = sys.stderr) return 2 _atomic_write_bytes(out, data) @@ -1227,7 +1222,7 @@ def cmd_colab_diff(args: argparse.Namespace) -> int: try: with urllib.request.urlopen(url, timeout = 15) as r: upstream_text = r.read().decode("utf-8", errors = "replace") - except (urllib.error.URLError, urllib.error.HTTPError, TimeoutError) as e: + except (urllib.error.URLError, TimeoutError) as e: print(f"::warning::colab-diff: could not fetch {url}: {e}") continue if not snap_path.exists():