Skip to content

Suggestions from at least certain pairs of linters should be combined #3019

@hippietrail

Description

@hippietrail

Here's a fairly typical typo for me. (My touchtyping seems to be degrading over the decades.)

Image

In this case a SpellCheck suggestion would've surely suggested the correct word, but I only got a less-than-useful suggestion from SplitWords. Sometimes the opposite happens.

In the past I'm pretty sure we used to see suggestions from multiple linters at once, at least in the Chrome extension. I assume this was disabled due it often being confusing and unhelpful.

But in some instances it is definitely the right thing to. Splitting words not in the dictionary and suggesting similarish single words from the dictionary for words not in the dictionary, are really similar when you think about it. There are fairly likely some other linters that might belong in this set too.

I can think of a few ways this might be improved:

  • Maybe just changing the code that removes overlapping lints is enough? Some tweaking of lint priorities might be needed.
  • Maybe a "layer" needs to be created where these two are handled in a special way that's somewhat apart from the other linters in some way.
  • Maybe they need to be combined into a single linter somehow. This is actually easy to do a quick solution for by making a new "wrapper" linter that calls these two and manually combines the suggestions. I recently put out a PR that wraps the SpellCheck linter with one that doesn't flag username mentions by just filtering out suggestions with @ in the right place. This is probably only suitable for a mockup.

Other ideas?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions