Focus trap in overlay campaigns

[jeffersonrabb]

• Accessibility exploration
• Homepage popups (PR: Popups On Non-Posts #28, Issue: Timed Pop-Ups On Home And Archives #23)
• Mailchimp block integration (Suppress Popups After Mailchimp Signup #27)
• Remove "Every Page View" option.
• Support for non-AMP requests. (Support For Non-AMP Requests #26)

[jeffersonrabb]

@thomasguillot could you jot down your findings on the a11y aspects of this plugin, for posterity?

[thomasguillot]

When the pop-up is visible. The keyboard navigation should only loop within the pop-up, until the dismiss (or submit...) button is clicked.

[thomasguillot]

The timed pop-up should be displayed after the header but before the content.

[adekbadek]

It looks like amp-lightbox component does not trap focus, so this can only be achieved in a non-AMP way.

For that, the focus-trap library can be used. Here's a POC: #298

[dkoo]

This hasn't changed according to recent AMP activity. I think we should put this issue on hold until we can replace amp-access with a unified way to check whether a prompt should be displayed (e.g. Bento).