Skip to content

Commit e3ea129

Browse files
NetyyyyCopilotmrm9084CopilotEldertGrootenboer
authored
Cherry pick for Spring Cloud Azure 6.3.0 (#48908)
* Fix: Skip App Configuration validation when feature is disabled (#47588) (cherry picked from commit 0d08d06) * Collection monitoring (#47648) * start collection monitoring * Updating collection monitoring * Updating State * Updated docs * cleaning up refresh * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixing tests * New tests * More new tests * Update AzureAppConfigDataLoader.java * Fixing Formatting * Update AppConfigurationReplicaClient.java * Code Review comments * review comments * code review items * Format fixing * fixing tests --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit f6267fc) * App Configuration Provider - Tag filters (#47985) * Tag Filter + Updated JavaDocs * Fixing tests * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * review comments * Tag Filter util file + tests * Update ValidationUtilTest.java * assertsame --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit e43ce23) * Load balance bug (#48121) * Fixes Load Balancing Bug * fixes * new version * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManagerTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit c237703) * fix(spring-messaging-servicebus): evict stale processors from cache (#48062) * fix(spring-messaging-servicebus): evict stale processors from cache (#48030) * chore: revert CHANGELOG entry per reviewer feedback * Update sdk/spring/spring-messaging-azure-servicebus/src/test/java/com/azure/spring/messaging/servicebus/core/DefaultServiceBusNamespaceProcessorFactoryTests.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: separate try-catch for listener notification and stale processor close Ensures stale.close() always executes even if listener notification throws, preventing a potential resource leak. * refactor: extract buildProcessorName to local variable in stale eviction block Avoids recomputing buildProcessorName(key) multiple times and ensures consistent value across debug log, listener callback, and warn logs. * test: add mock-based tests for running-to-not-running processor transition - Add testRunningProcessorReturnedFromCache: verifies running processor stays in cache without eviction - Add testProcessorEvictedAfterTransitionToNotRunning: verifies stale (non-running) processor is evicted, closed, and replaced - Update comments on existing stale tests to clarify they test never-started processors; reference new mock tests for transition - Add reflection helper getProcessorMap() for injecting mocks into cache --------- Co-authored-by: Eldert Grootenboer (from Dev Box) <egrootenboer@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 1c16e17) * Fix: KeyVaultJcaProvider registered at highest JCA priority breaks mTLS with standard keystores (#48198) * Initial plan * Fix: KeyVaultJcaProvider registered at highest priority breaks mTLS with standard keystores Co-authored-by: rujche <171773178+rujche@users.noreply.github.com> * Revert spring-cloud-azure-autoconfigure/CHANGELOG.md - keep aligned with other versions Co-authored-by: rujche <171773178+rujche@users.noreply.github.com> * Update CHANGELOG issue link to #48183 Co-authored-by: rujche <171773178+rujche@users.noreply.github.com> * Apply PR review suggestions: remove unused param and use PROVIDER_NAME constant Co-authored-by: rujche <171773178+rujche@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rujche <171773178+rujche@users.noreply.github.com> (cherry picked from commit 7f9adaf) * update changelog * App Config Spring - Json content type fix (#48448) * fixing semi colon support * Update CHANGELOG.md * bug fix * review comments * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * remove release notes * Update JsonConfigurationParser.java * Update JsonConfigurationParser.java * Update JsonConfigurationParser.java * Update JsonConfigurationParser.java --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> (cherry picked from commit c0c405a) * update changelog * App Config - Startup retry (#47857) * Refactor + Startup Retry * Update AzureAppConfigDataLoader.java * Adding Tests * Updating readme, correct location * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * interval change * fixes after merge * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update AzureAppConfigDataLoader.java * review comments * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 02491f7) * App Config Spring - Refresh Refactor (#47877) * Refactor Refresh * review fixes * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update StateHolderTest.java * Update AppConfigurationRefreshUtil.java * Update AppConfigurationRefreshUtil.java * Update sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/StateHolder.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update AzureAppConfigBootstrapRegistrar.java * Update AppConfigurationRefreshUtilTest.java * Update ConnectionManager.java * Update AppConfigurationRefreshUtilTest.java * fixing after merge * Update AppConfigurationRefreshUtilTest.java * fixing tests * fixing merge issue * Update RecurrenceEvaluator.java * Update RecurrenceEvaluator.java * better fix * new fix * Update AppConfigurationWatchAutoConfiguration.java * Update AppConfigurationPullRefresh.java * Update AppConfigurationPullRefresh.java --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit dcd90d0) * Fixing Load Balancing shuffle (#48274) * Fixing Load Balancing shuffle * Update ConnectionManager.java * Update ConnectionManager.java (cherry picked from commit bb97593) * Bug 47910.count query text block (#47911) * RED: isCountQuery() should return true for queries in text blocks * GREEN: isCountQuery() should return true for queries in text blocks * RED: isSumQuery() should return true for sum query in java text block * GREEN: isSumQuery() should return true for sum query in java text block --------- Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com> (cherry picked from commit d3f381d) * Fix flaky AddressRepositoryIT tests due to non-deterministic ordering and ambiguous IDs (#48071) * Initial plan * Fix flaky AddressRepositoryIT tests - order-sensitive assertions and ambiguous findById Co-authored-by: kushagraThapar <14034156+kushagraThapar@users.noreply.github.com> * Remove unused TEST_ADDRESS_TEMP variables from testFindAllByStreetNotNull and testCountByStreetNotNull Co-authored-by: kushagraThapar <14034156+kushagraThapar@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kushagraThapar <14034156+kushagraThapar@users.noreply.github.com> Co-authored-by: Rujun Chen <rujche@microsoft.com> (cherry picked from commit 6cf1688) * Startup Bug Fixes (#48278) * Startup Bug Fixes * Update README.md * Update AppConfigurationProperties.java --------- Co-authored-by: Nishant Routray <nroutray@microsoft.com> (cherry picked from commit 35d4a6c) * Daylight saving time fix (#48363) * Daylight saving time fix * dst tests * test updates * Update RecurrenceEvaluator.java * test update * Update RecurrenceValidatorDSTTest.java * copilot comments * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> (cherry picked from commit c57f2d2) * update changelog * update changelog * update changelog * fix * sync eng/pipelines * sync eng/common --------- Co-authored-by: Copilot <198982749+copilot@users.noreply.github.com> Co-authored-by: Matthew Metcalf <mrm9084@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Eldert Grootenboer <eldert@eldert.net> Co-authored-by: Jason Bodnar <jason.bodnar@blackbaud.com> Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com> Co-authored-by: kushagraThapar <14034156+kushagraThapar@users.noreply.github.com> Co-authored-by: Rujun Chen <rujche@microsoft.com>
1 parent 6265f61 commit e3ea129

92 files changed

Lines changed: 5529 additions & 1860 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

eng/common/instructions/azsdk-tools/create-release-plan.instructions.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,9 @@ If any details are missing, prompt the user accordingly:
2929
- **Service Tree ID**: GUID format identifier for the service in Service Tree. Before creating release plan, always show the value to user and ask them to confirm it's a valid value in service tree.
3030
- **Product Service Tree ID**: GUID format identifier for the product in Service Tree. Before creating release plan, always show the value to user and ask them to confirm it's a valid value in service tree.
3131
- **Expected Release Timeline**: Format must be in "Month YYYY"
32-
- **API Version**: The version of the API being released
3332
- **SDK Release Type**: Value must be beta or stable.
34-
- "beta" for preview API versions
35-
- "stable" for GA API versions
33+
- "beta"
34+
- "stable"
3635

3736
## Step 4: Create Release Plan
3837
- If the user doesn't know the required details, direct them to create a release plan using the release planner

eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md

Lines changed: 48 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ Help the user generate and build SDKs locally from TypeSpec API specifications u
88
High level steps involved:
99
1. Generate SDK locally
1010
2. Build / Compile SDK locally
11-
3. Run package checks
12-
4. Run package tests
13-
5. Update change log, metadata and version
11+
3. Commit generated changes checkpoint
12+
4. Run package checks
13+
5. Run package tests
14+
6. Update changelog, metadata and version
15+
7. Commit final changes checkpoint
1416

1517
---
1618

@@ -21,7 +23,7 @@ High level steps involved:
2123
**Goal**: Ensure the user understands the overall SDK generation and build process before starting.
2224
**Actions**:
2325

24-
- Present the high-level steps involved in generating and building SDK locally:
26+
- **MUST** present the high-level steps involved in generating and building SDK locally:
2527
1. Select target language
2628
2. Verify SDK repository
2729
3. Validate repository path
@@ -30,7 +32,11 @@ High level steps involved:
3032
6. Generate SDK using `azsdk_package_generate_code` MCP tool
3133
7. Identify SDK project path
3234
8. Build/Compile SDK using `azsdk_package_build_code` MCP tool
33-
- Ask the user to confirm readiness to proceed.
35+
9. Commit generated changes checkpoint
36+
10. Run package checks
37+
11. Run package tests
38+
12. Update changelog, metadata and version
39+
13. Commit final changes checkpoint
3440

3541
---
3642

@@ -132,26 +138,58 @@ High level steps involved:
132138

133139
---
134140

135-
### Step 3: Run package validation
141+
### Step 3: Stage checkpoint — Commit generated changes
142+
143+
**Goal**: Prompt the user to commit the changes produced by the generation and build steps before proceeding to validation and testing.
144+
**Actions**:
145+
146+
- **MUST** inform the user that SDK generation and build have completed successfully.
147+
- **MUST** prompt the user to decide if they want to commit the changes now. Do NOT skip this prompt.
148+
- If the user chooses to commit:
149+
- Check if the user is on the `main` branch. If so, prompt: *"You are currently on the main branch. Please create a new branch using `git checkout -b <branch-name>` before proceeding."* Suggest a reasonable default branch name based on the generation context (e.g., `sdk/<service-name>/<package-name>`) and provide the exact `git checkout -b <branch-name>` command for the user to run. Allow the user to provide a preferred branch name instead. Wait for user confirmation before continuing.
150+
- Run `git add <modified-files>` to stage the changed files.
151+
- Prompt the user for a commit message.
152+
- Run `git commit -m "<user-provided-message>"`.
153+
- If the user chooses to skip, acknowledge and proceed to the next step.
154+
155+
---
156+
157+
### Step 4: Run package checks
136158

137159
**Actions**:
138160

139161
- Run `azsdk_package_run_check` MCP tool to validate the generated SDK package in the identified project directory.
140162

141163
---
142164

143-
### Step 4: Run package tests
165+
### Step 5: Run package tests
144166

145167
**Actions**:
146168

147169
- Run `azsdk_package_run_tests` MCP tool to run tests on the generated SDK package in the identified project directory.
148170

149171
---
150172

151-
### Step 5: Update change log, metadata and version
173+
### Step 6: Update changelog, metadata and version
152174

153175
**Actions**:
154176

177+
- Run `azsdk_package_update_changelog_content` MCP tool to update changelog in the identified project directory.
155178
- Run `azsdk_package_update_metadata` MCP tool to update metadata in the identified project directory.
156-
- Run `azsdk_package_update_changelog_content` MCP tool to update change log in the identified project directory.
157-
- Run `azsdk_package_update_version` MCP tool to update version in the identified project directory.
179+
- Run `azsdk_package_update_version` MCP tool to update version in the identified project directory.
180+
181+
---
182+
183+
### Step 7: Stage checkpoint — Commit final changes
184+
185+
**Goal**: Prompt the user to commit the final set of changes after all updates are complete.
186+
**Actions**:
187+
188+
- **MUST** inform the user that changelog, metadata, and version updates are complete.
189+
- **MUST** prompt the user to decide if they want to commit the changes now. Do NOT skip this prompt.
190+
- If the user chooses to commit:
191+
- Check if the user is on the `main` branch. If so, prompt: *"You are currently on the main branch. Please create a new branch using `git checkout -b <branch-name>` before proceeding."* Suggest a reasonable default branch name based on the generation context (e.g., `sdk/<service-name>/<package-name>`) and provide the exact `git checkout -b <branch-name>` command for the user to run. Allow the user to provide a preferred branch name instead. Wait for user confirmation before continuing.
192+
- Run `git add <modified-files>` to stage the changed files.
193+
- Prompt the user for a commit message.
194+
- Run `git commit -m "<user-provided-message>"`.
195+
- If the user chooses to skip, acknowledge and proceed.
Lines changed: 10 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,12 @@
11
---
2-
description: 'Identify languages configured in the TypeSpec project and add it to release plan'
2+
description: 'Update SDK details in a release plan from a TypeSpec project'
33
---
4-
# Step 1: Find the list of languages and package names
5-
**Goal**: Identify languages configured in the TypeSpec project and generate the json object with language and package name.
6-
1. Identify the language emitter configuration in the `tspconfig.yaml` file in the TypeSpec project root.
7-
2. Identify the package name or namespace for each language emitter.
8-
- For Java and Python, use `emitter-output-dir` for package name if it exists. Otherwise use `package-dir` to get the package name as fallback approach.
9-
- For .NET, use namespace property to get package name.
10-
- For JavaScript, use `packagedetails:name` property to get package name.
11-
- For Go, use module name and remove `github.com/Azure/azure-sdk-for-go/` to get package name.
12-
3. Map the language name in emitter to one of the following in Pascal case(except .NET):
13-
- .NET
14-
- Java
15-
- Python
16-
- JavaScript
17-
- Go
18-
4. Create a JSON array object with the following structure:
19-
```json
20-
[
21-
{
22-
"language": "<LanguageName>",
23-
"packageName": "<PackageName>"
24-
},
25-
...
26-
]
27-
```
28-
5. If no languages are configured, inform the user: "No languages configured in TypeSpec project. Please add at least one language emitter in tspconfig.yaml."
29-
**Success Criteria**: JSON object with languages and package names created.
4+
# Step 1: Identify the TypeSpec project path
5+
**Goal**: Identify the path to the TypeSpec project that contains the `tspconfig.yaml` file.
6+
1. Identify the TypeSpec project directory that contains a `tspconfig.yaml` file.
7+
2. If a TypeSpec project path is not provided or known, ask the user for the path.
8+
3. If no `tspconfig.yaml` exists at the given path, inform the user: "No tspconfig.yaml found at the given path. Please provide a valid TypeSpec project path."
9+
**Success Criteria**: Valid TypeSpec project path identified.
3010

3111
# Step 2: Check if release plan exists
3212
**Goal**: Determine if a release plan exists for the API spec pull request or work item Id or release plan Id in current context.
@@ -36,17 +16,7 @@ description: 'Identify languages configured in the TypeSpec project and add it t
3616
**Success Criteria**: Release plan exists or user informed to create one.
3717

3818
# Step 3: Update Release Plan with SDK Information
39-
> **(MANDATORY - DO NOT SKIP) ALWAYS validate all package names against the format rules AND the examples table before calling any update tool, even if the user provides SDK details directly. Auto-correct and inform the user of invalid package names.**
40-
> - **JavaScript**: Must start with `@azure/`
41-
> - **Go**: Must start with `sdk/`
42-
>
43-
> **Valid package name examples (compare against these to catch invalid formats):**
44-
> | Language | Valid | Invalid |
45-
> |----------|-------|---------|
46-
> | JavaScript | `@azure/arm-compute` | `arm-compute`, `azure/arm-compute`,`@azure-arm-compute` |
47-
> | Go (management plane) | `sdk/resourcemanager/compute/armcompute` | `sdk/armcompute`, `/sdk/compute`, `github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute` |
48-
49-
**Goal**: Update the release plan with the languages and package names identified in Step 1.
50-
1. Use `azsdk_update_sdk_details_in_release_plan` to update the release plan work item with the JSON object created in Step 1.
19+
**Goal**: Update the release plan with the SDK package names resolved from the TypeSpec project.
20+
1. Use `azsdk_update_sdk_details_in_release_plan` with the release plan work item ID and the TypeSpec project path from Step 1.
5121
2. Confirm successful update of the release plan with the SDK information and summary of languages and package names.
52-
**Success Criteria**: Release plan updated with languages and package names.
22+
**Success Criteria**: Release plan updated with languages and package names resolved from the TypeSpec project.

eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Follow the steps in #file:local-sdk-workflow.instructions.md to generate and bui
4444
- Execute the SDK generation pipeline with the following required parameters for all languages:
4545
- TypeSpec project root path
4646
- API spec pull request number (if the API spec is not merged to the main branch, otherwise use 0)
47-
- API version
47+
- API version (optional)
4848
- SDK release type (`beta` for preview API versions, `stable` otherwise)
4949
- Language options:
5050
For management plane: `Python`, `.NET`, `JavaScript`, `Java`, `Go`

eng/common/instructions/azsdk-tools/validate-codeowners.instructions.md

Lines changed: 0 additions & 74 deletions
This file was deleted.

eng/common/mcp/azure-sdk-mcp.ps1

Lines changed: 37 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
#Requires -PSEdition Core
55

66
param(
7-
[string]$FileName = 'Azure.Sdk.Tools.Cli',
8-
[string]$Package = 'azsdk',
97
[string]$Version, # Default to latest
108
[string]$InstallDirectory = '',
119
[string]$Repository = 'Azure/azure-sdk-tools',
@@ -15,11 +13,14 @@ param(
1513
[switch]$UpdatePathInProfile
1614
)
1715

18-
$ErrorActionPreference = "Stop"
16+
$ErrorActionPreference = 'Stop'
1917
. (Join-Path $PSScriptRoot '..' 'scripts' 'Helpers' 'AzSdkTool-Helpers.ps1')
2018

2119
$toolInstallDirectory = $InstallDirectory ? $InstallDirectory : (Get-CommonInstallDirectory)
2220

21+
$packageName = 'azsdk'
22+
$packageFileName = 'Azure.Sdk.Tools.Cli'
23+
2324
$mcpMode = $Run
2425

2526
# Log to console or MCP client json-rpc
@@ -103,14 +104,40 @@ $tmp = $env:TEMP ? $env:TEMP : [System.IO.Path]::GetTempPath()
103104
$guid = [System.Guid]::NewGuid()
104105
$tempInstallDirectory = Join-Path $tmp "azsdk-install-$($guid)"
105106

107+
# If already installed, use first class version mechanism
108+
$azsdkCmd = Get-Command -ErrorAction Ignore $packageName
109+
if ($azsdkCmd -and !$InstallDirectory) {
110+
$ErrorActionPreference = "Stop"
111+
$upgrade = & $packageName upgrade --check --output json | out-string
112+
if (!$LASTEXITCODE) {
113+
$ErrorActionPreference = 'Ignore'
114+
$localVersion = $upgrade | ConvertFrom-Json -AsHashtable
115+
$ErrorActionPreference = 'Stop'
116+
if ($localVersion -and $localVersion.old_version -and $localVersion.old_version -eq ($Version ? $Version : $localVersion.new_version)) {
117+
log "Version up to date at $($localVersion.old_version)"
118+
if ($Run) {
119+
$proc = Start-Process -PassThru -WorkingDirectory $RunDirectory -FilePath $azsdkCmd.Path -ArgumentList 'mcp' -NoNewWindow -Wait
120+
exit $proc.ExitCode
121+
}
122+
exit 0
123+
}
124+
if ($localVersion) {
125+
log "Version not up to date at " + $localVersion.old_version
126+
} else {
127+
log "Failed to parse version:"
128+
log $upgrade
129+
}
130+
}
131+
}
132+
106133
if ($mcpMode) {
107134
try {
108135
# Swallow all output and re-log so we can wrap any
109136
# output from the inner function as json-rpc
110137
$tempExe = Install-Standalone-Tool `
111138
-Version $Version `
112-
-FileName $FileName `
113-
-Package $Package `
139+
-FileName $packageFileName `
140+
-Package $packageName `
114141
-Directory $tempInstallDirectory `
115142
-Repository $Repository `
116143
*>&1
@@ -126,8 +153,8 @@ if ($mcpMode) {
126153
else {
127154
$tempExe = Install-Standalone-Tool `
128155
-Version $Version `
129-
-FileName $FileName `
130-
-Package $Package `
156+
-FileName $packageFileName `
157+
-Package $packageName `
131158
-Directory $tempInstallDirectory `
132159
-Repository $Repository `
133160

@@ -164,7 +191,7 @@ if (Test-Path $tempInstallDirectory) {
164191
}
165192

166193
if ($updateSucceeded) {
167-
log "Executable $package is installed at $exeDestination"
194+
log "Executable $packageName is installed at $exeDestination"
168195
}
169196
if (!$UpdatePathInProfile) {
170197
log -warn "To add the tool to PATH for new shell sessions, re-run with -UpdatePathInProfile to modify the shell profile file."
@@ -175,5 +202,6 @@ else {
175202
}
176203

177204
if ($Run) {
178-
Start-Process -WorkingDirectory $RunDirectory -FilePath $exeDestination -ArgumentList 'start' -NoNewWindow -Wait
205+
$proc = Start-Process -PassThru -WorkingDirectory $RunDirectory -FilePath $exeDestination -ArgumentList 'mcp' -NoNewWindow -Wait
206+
exit $proc.ExitCode
179207
}

eng/common/pipelines/templates/jobs/prepare-pipelines.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ jobs:
107107
}
108108
"rust" {
109109
$generatePublicCIPipeline = 'false'
110-
$internalVariableGroups = '$(AzureSDK_CratesIo_Release_Pipeline_Secrets) $(Release_Secrets_for_GitHub) $(APIReview_AutoCreate_Configurations) $(Secrets_for_Resource_Provisioner)'
111110
$generateUnifiedWeekly = 'true'
111+
$internalVariableGroups = '$(Release_Secrets_for_GitHub) $(APIReview_AutoCreate_Configurations)'
112112
}
113113
"net" {
114114
$generatePublicCIPipeline = 'false'

eng/common/pipelines/templates/steps/bypass-local-dns.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ steps:
2121
New-Item -Path $parentFolder -ItemType Directory | Out-Null
2222
}
2323
24-
$content = "registry=${{ parameters.registryUrl }}`n`nalways-auth=true"
24+
$content = "registry=${{ parameters.registryUrl }}"
2525
$content | Out-File '${{ parameters.npmrcPath }}'
2626
displayName: 'Create .npmrc'
2727
condition: ${{ parameters.CustomCondition }}

eng/common/pipelines/templates/steps/create-tags-and-git-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ steps:
2525
timeoutInMinutes: 5
2626
env:
2727
GH_TOKEN: $(azuresdk-github-pat)
28+
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
2829
${{ if ne(parameters.NpmConfigUserConfig, '') }}:
2930
NPM_CONFIG_USERCONFIG: ${{ parameters.NpmConfigUserConfig }}
3031
${{ if ne(parameters.NpmConfigRegistry, '') }}:

0 commit comments

Comments
 (0)