refactor(Settings): rename cache variable for clarity and optimize page build logic

- Renamed `SortedPagesCache` to `_sortedPagesCache` for improved clarity and consistency in naming conventions.
- Updated references throughout the code to reflect the new variable name, ensuring proper cache invalidation during settings changes.
- Simplified the page build logic in `RitsuModSettingsSubmenu` to enhance performance and maintainability by consolidating yield conditions.

Author: BAKAOLC

Settings/ModSettings/Core/ModSettingsRegistry.cs

@@ -38,7 +38,7 @@ public static class ModSettingsRegistry
         ///     <see cref="InvalidateOrderingCache" />）。重建开销很大（多键排序 + 逐页本地化），而设置 UI 每次刷新
         ///     都会多次调用 <see cref="GetPages" />，因此在真正发生变化前复用该快照。
         /// </summary>
-        private static IReadOnlyList<ModSettingsPage>? SortedPagesCache;
+        private static IReadOnlyList<ModSettingsPage>? _sortedPagesCache;
 
         /// <summary>
         ///     True after at least one page has been registered.
@@ -66,7 +66,7 @@ public static void Register(ModSettingsPage page)
             lock (SyncRoot)
             {
                 PagesById[CreateCompositeId(page.ModId, page.Id)] = page;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
             }
         }
 
@@ -81,7 +81,7 @@ public static void InvalidateOrderingCache()
         {
             lock (SyncRoot)
             {
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
             }
         }
 
@@ -97,7 +97,7 @@ public static void RegisterModDisplayName(string modId, ModSettingsText displayN
             lock (SyncRoot)
             {
                 ModDisplayNames[modId] = displayName;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
             }
         }
 
@@ -128,7 +128,7 @@ public static void RegisterModSidebarOrder(string modId, int order)
             lock (SyncRoot)
             {
                 ModSidebarOrders[modId] = order;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
             }
         }
 
@@ -146,7 +146,7 @@ public static void RegisterPageSortOrder(string modId, string pageId, int sortOr
             lock (SyncRoot)
             {
                 PageSortOverrides[CreateCompositeId(modId, pageId)] = sortOrder;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
             }
         }
 
@@ -176,7 +176,7 @@ public static bool TryRegisterPageSortOrderAfter(string modId, string pageId, st
                 var baseOrder =
                     PageSortOverrides.GetValueOrDefault(CreateCompositeId(modId, afterPageId), after.SortOrder);
                 PageSortOverrides[CreateCompositeId(modId, pageId)] = baseOrder + gap;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
                 return true;
             }
         }
@@ -207,7 +207,7 @@ public static bool TryRegisterPageSortOrderBefore(string modId, string pageId, s
                 var baseOrder = PageSortOverrides.GetValueOrDefault(CreateCompositeId(modId, beforePageId),
                     before.SortOrder);
                 PageSortOverrides[CreateCompositeId(modId, pageId)] = baseOrder - gap;
-                SortedPagesCache = null;
+                _sortedPagesCache = null;
                 return true;
             }
         }
@@ -278,7 +278,7 @@ public static IReadOnlyList<ModSettingsPage> GetPages()
         {
             lock (SyncRoot)
             {
-                return SortedPagesCache ??= PagesById.Values
+                return _sortedPagesCache ??= PagesById.Values
                     .OrderBy(page => ModSidebarOrders.GetValueOrDefault(page.ModId, 0))
                     .ThenBy(page => ModSettingsLocalization.ResolveModNameFallback(page.ModId, page.ModId),
                         StringComparer.OrdinalIgnoreCase)

Settings/ModSettingsUi/Core/RitsuModSettingsSubmenu.cs

@@ -1956,11 +1956,9 @@ private async Task BuildPageAsync(ModSettingsPage page, PageContentCache cache)
                         return;
 
                     nextContent.AddChild(item.Control);
-                    if (item.YieldAfter && Time.GetTicksMsec() - lastYieldMsec >= PageBuildFrameBudgetMsec)
-                    {
-                        await this.AwaitRitsuProcessFrame(ct);
-                        lastYieldMsec = Time.GetTicksMsec();
-                    }
+                    if (!item.YieldAfter || Time.GetTicksMsec() - lastYieldMsec < PageBuildFrameBudgetMsec) continue;
+                    await this.AwaitRitsuProcessFrame(ct);
+                    lastYieldMsec = Time.GetTicksMsec();
                 }
 
                 if (buildVersion != cache.BuildVersion || !IsInstanceValid(cache.Root))