Skip to content

Commit ddc0ce6

Browse files
committed
refactor(CardPiles, CardTags, Keywords): streamline resolution methods for improved readability
- Consolidated the logic in `GetPileType`, `GetCardTag`, and `GetCardKeyword` methods to simplify the return statements, enhancing code clarity and maintainability. - This change reduces redundancy by combining the parsing and retrieval processes into a single return statement, improving overall efficiency.
1 parent b1bacc7 commit ddc0ce6

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

CardPiles/ModCardPileRegistry.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,10 +296,7 @@ public static bool TryResolvePileType(string idOrEnumName, out PileType value)
296296
return true;
297297
}
298298

299-
if (Enum.TryParse(idOrEnumName.Trim(), true, out value))
300-
return true;
301-
302-
return TryGetPileType(idOrEnumName, out value);
299+
return Enum.TryParse(idOrEnumName.Trim(), true, out value) || TryGetPileType(idOrEnumName, out value);
303300
}
304301

305302
/// <summary>

CardTags/ModCardTagRegistry.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,7 @@ public static bool TryResolveCardTag(string idOrEnumName, out CardTag value)
211211
return true;
212212
}
213213

214-
if (Enum.TryParse(idOrEnumName.Trim(), true, out value))
215-
return true;
216-
217-
return TryGetCardTag(idOrEnumName, out value);
214+
return Enum.TryParse(idOrEnumName.Trim(), true, out value) || TryGetCardTag(idOrEnumName, out value);
218215
}
219216

220217
/// <summary>

Keywords/ModKeywordRegistry.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,10 +469,7 @@ public static bool TryResolveCardKeyword(string idOrEnumName, out CardKeyword va
469469
return true;
470470
}
471471

472-
if (Enum.TryParse(idOrEnumName.Trim(), true, out value))
473-
return true;
474-
475-
return TryGetCardKeyword(idOrEnumName, out value);
472+
return Enum.TryParse(idOrEnumName.Trim(), true, out value) || TryGetCardKeyword(idOrEnumName, out value);
476473
}
477474

478475
/// <summary>

0 commit comments

Comments
 (0)