test(install): make reprobe test guard the block-list skip regression

[BANANASJIM]

Summary

Surfaced by an adversarial review of the #355 install-migration hardening (#365). The reprobe unit test was green-but-blind to the exact regression it should catch.

• install: reprobe writes only driverless interfaces used a fixture entry with an empty block_kernel_drivers.
• A block_kernel_drivers.len != 0 skip in probeAndReprobeDrivers (the guard explicitly rejected during fix(install): apply block_kernel_drivers changes to connected devices and across install modes #365 review, because it would strand the real Vader 5 whose block list is ["xpad"]) would NOT skip an empty-block entry — so the test passed even with that regression present.
• Pin the fixture's block list to ["xpad"] so it mirrors production and fails on that skip.

Test-only change; no production behavior change.

Test plan

Verified in the canonical Docker image (zig 0.15.2):

• Clean: zig build test -Dtest-filter="install: reprobe" passes.
• Inject if (entry.block_kernel_drivers.len != 0) continue; into probeAndReprobeDrivers → the test fails at the 1-1.4:1.1 write assertion (falsifiability confirmed).
• Remove the skip → passes.
• zig build test-tsan -Dtest-filter="install: reprobe" passes.

Summary by CodeRabbit

• Tests
  • Updated test fixtures to ensure correct validation of reprobe behavior.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e376383-c39e-49d6-b129-75310313c0eb

📥 Commits

Reviewing files that changed from the base of the PR and between c7c8a48 and 2c5936d.

📒 Files selected for processing (1)

• src/cli/install/tests.zig

---

📝 Walkthrough

Walkthrough

The reprobe driverless-interface test's entries fixture is updated to include a non-empty block_kernel_drivers list, ensuring the test continues to assert correct reprobe behavior when that list is populated.

Changes

Reprobe Test Fixture Update

Layer / File(s)	Summary
Reprobe driverless interface test fixture update src/cli/install/tests.zig	The test fixture entries array is updated to set block_kernel_drivers to a non-empty slice (&.{"xpad"}) with comments clarifying the intent to exercise the non-empty block list path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• BANANASJIM/padctl#365: Updates the same reprobe test fixture to account for block_kernel_drivers-dependent behavior in the install path.
• BANANASJIM/padctl#362: Alters the block_kernel_drivers configuration to block only xpad, affecting the same reprobe test's input conditions.

Poem

🐰 A test needs teeth to catch the path,
Where drivers block and filters clash,
Now xpad hops into the pen,
To prove reprobe works once again! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: updating a reprobe test to guard against a regression by ensuring the block-list skip behavior is testable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/355-reprobe-guard-falsifiable

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}