From 2c5936d285b77a7f71b97d833eae7367b9133181 Mon Sep 17 00:00:00 2001 From: BANANASJIM Date: Fri, 5 Jun 2026 01:13:34 -0700 Subject: [PATCH] test(install): make reprobe test guard the block-list skip regression The reprobe fixture used an entry with an empty block_kernel_drivers, so a `block_kernel_drivers.len != 0` skip in probeAndReprobeDrivers (which would strand the real Vader 5, block list ["xpad"]) left the test green. Pin the fixture's block list to mirror production so the test fails on that regression. Verified in the canonical Docker image: injecting the skip flips the test to fail; removing it passes. --- src/cli/install/tests.zig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cli/install/tests.zig b/src/cli/install/tests.zig index 08a4ed6..7876d10 100644 --- a/src/cli/install/tests.zig +++ b/src/cli/install/tests.zig @@ -3728,10 +3728,14 @@ test "install: reprobe writes only driverless interfaces" { defer f.close(); } + // Non-empty block list mirrors the real Vader 5: re-probe must rebind a + // driverless interface regardless of block_kernel_drivers, so this fixture + // also guards against a `block_kernel_drivers.len != 0` skip in the path. const entries = [_]UdevEntry{.{ .name = "Test Device", .vid = 0x37d7, .pid = 0x2401, + .block_kernel_drivers = &.{"xpad"}, }}; probeAndReprobeDrivers(allocator, &entries, tmp_path);