Merge pull request #51 from samTime101/optional/envs

Made GITHUB related envs optional and validation is skipped for 'test' environments

Author: Aayush0966

.env.example

@@ -5,4 +5,9 @@ BETTER_AUTH_URL=
 NODE_ENV=
 JWT_ACCESS_SECRET=
 JWT_REFRESH_SECRET=
+CLOUDINARY_CLOUD_NAME=
+CLOUDINARY_API_KEY=
+CLOUDINARY_API_SECRET=
+GITHUB_SECRET=
+GITHUB_CLIENT_ID=
 GITHUB_TOKEN=

src/index.ts

@@ -18,12 +18,21 @@ import projectRouter from "./routers/project.router";
 
 const requiredEnvVars = [
   'CORS_ORIGIN',
-  'GITHUB_CLIENT_ID',
-  'GITHUB_SECRET',
   'BETTER_AUTH_SECRET',
   'BETTER_AUTH_URL'
 ];
 
+// OPTIONAL ENV VARS
+const optionalEnvVars = ["GITHUB_CLIENT_ID", "GITHUB_SECRET"];
+optionalEnvVars.forEach((env) => {
+  if (!process.env[env]) {
+    process.env[env] = "";
+  }
+  console.info(`${env} IS ${process.env[env] ? "CONFIGURED" : "NOT CONFIGURED DEFAULTING TO EMPTY STRING"}`);
+});
+
+
+
 function validateEnvironment() {
   const missing = requiredEnvVars.filter(env => !process.env[env]);
   if (missing.length > 0) {
@@ -123,9 +132,13 @@ async function startServer() {
   try {
     console.log('🚀 Starting DevSphere Backend...');
 
-    validateEnvironment();
 
-    await checkDatabaseConnection();
+    // SO I FOUND OUT THAT IN VITEST THE NODE_ENV IS SET TO "test"
+    // SO NO NEED TO SET IT MANUALLY IN GITHUB ACTIONS
+    if(NODE_ENV != "test") {
+      validateEnvironment();
+      await checkDatabaseConnection();
+    }
 
     // Start the server
     app.listen(port, () => {

src/tests/order.test.ts

@@ -9,5 +9,5 @@ import '@/tests/01-events/02-event.test';
 import '@/tests/01-events/03-update.test';
 import '@/tests/01-events/04-list.test';
 import '@/tests/01-events/05-delete.test';
-import '@/tests/02-member/01-create.test';
+// import '@/tests/02-member/01-create.test';
 // import '@/tests/03-user/01-signin.test';