Skip to content

Several skill-bypass issues with held attributes, imbued weapons, and on-hit effects (Forge 1.20.1) #63

@asusis

Description

@asusis

Mod version: Reskillable Reimagined 4.6.2.1 for Forge 1.20.1
Other relevant mods: Iron’s Spells and Spellbooks, Dreadsteel, anything else involved
Expected behavior: If the player does not meet the skill requirement, they should not gain held-item attributes, should not be able to bypass weapon restrictions through imbues, and on-hit effects should not still cause damage.
Actual behavior:

  1. Holding an item still grants its attributes even without meeting the item’s skill requirement.
  2. Imbuing a weapon can let the player attack with it even if they do not meet the weapon’s own requirement.
  3. Some weapons trigger hit-animation-based mod effects (an effect that happens after a weapon swing) even when direct damage is blocked due to insufficient level of the skill.
    Steps to reproduce:
  1. Add an item from the Iron's Spells 'n Spellbooks mod with magic attributes to the reskillable skill locks config.
    Set player skill below required level.
    Hold an item with attribute bonuses.
    Observe that the attributes still apply.
  2. Imbue a restricted weapon with an allowed spell (do not add the spell to the skill lock config, or if you do, set the required skill level for that spell to the player's level).
    Attack and observe that the weapon/effect can still function.
  3. Test with Dreadsteel or another mod that hooks into hit animation (first add the weapon to the skill locks config and then set player's skill below the required level) and you will see that the weapon's projectile/effect still spawns.

Notes: This seems broader than just Iron’s Spells and Spellbooks because custom attributes from other mods are also affected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions