Index out of bounds display error

[BarbourSmith]

I am sometimes running into an issue where things stop displaying correctly with the error:

Error in generateDisplayMesh: Failed to deserialize geometry: RuntimeError: index out of bounds Error: Failed to deserialize geometry: RuntimeError: index out of bounds
    get https://abundance.maslowcnc.com/assets/meshWorker-DfHOGBgL.js:61
[meshWorker-DfHOGBgL.js:61:22364](https://abundance.maslowcnc.com/assets/meshWorker-DfHOGBgL.js)
    og https://abundance.maslowcnc.com/assets/meshWorker-DfHOGBgL.js:61

The only fix seems to be to refresh the page and then all is well.

[tristan-huber]

Huh, I haven't seen this one before. The Copilot fix seems like a passable stop-gap but the real problem is that we're adding contents to the indexedDB which we can't de-serialize later. The logging added in that PR could help, ie logging the id of the shape which is failing deserialize will tell us at least what atom type is generating these problems (presumably the code atom though).

At a guess, this is probably being caused by some issue with wrapping code atom results which is allowing us to write an incorrect structure into the indexedDB. I'll have a look this afternoon. Though the fact that a refresh fixes things isn't consistent with this theory... so possibly I'm missing something.

[tristan-huber]

Hmm ok, I haven't been able to repro this, so maybe we can dig into it in person tomorrow.

The only possibly related thing I found in the code was a couple missing await's near the end of the new code execution path. That could cause some race issues with code atom results since it would allow the mesh thread to try to extract a geometry before from the cache it's finished writing. But I wouldn't really expect that to show up as this specific error.

In any case, those awaits (and finally getting the linter set up) have been merged in here: #1696

[BarbourSmith]

I haven't been able to repo it reliably either. It just seems to happen occasionally (but not often). I'll keep an eye on it.