You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #18, which lands preview_hard_zoom.png (front/side/top/iso of a hard example) as a bench2 preview output but only warns when a family PR is missing it.
Reason for warning first: PRs branched before #18 cannot generate the file, and main itself is not yet conformant. Hard-failing on day one would have turned 11 open community PRs red at once.
To flip it to required
Backfill main — re-run uv run bench2 preview <family> and commit preview_hard_zoom.png for the families merged without it: slotted_din_rail, speaker_pole_mount_socket (one PR per family, per the one-family rule).
Flip the gate — in .github/workflows/family-pr-checks.yml, move preview_hard_zoom.png from step 3b (warn) into step 3's required-files loop, restore the "seven files" wording in the step-3 error message, the header comment, CONTRIBUTING.md's gate table, and drop the "warns while … backfill" caveat.
Steps 1 and 2 can happen in any order; step 3 only after both are done, so no PR goes red for something its author could not have produced.
Follow-up to #18, which lands
preview_hard_zoom.png(front/side/top/iso of a hard example) as abench2 previewoutput but only warns when a family PR is missing it.Reason for warning first: PRs branched before #18 cannot generate the file, and
mainitself is not yet conformant. Hard-failing on day one would have turned 11 open community PRs red at once.To flip it to required
main— re-runuv run bench2 preview <family>and commitpreview_hard_zoom.pngfor the families merged without it:slotted_din_rail,speaker_pole_mount_socket(one PR per family, per the one-family rule).main, re-runbench2 preview, commit the fourth render): [family] minifix_cam_housing: Häfele Minifix 15 connector housing #34, [family] set_screw_shaft_collar: GN 705 / DIN 705 set collar #36, [family-assembly] cabinet_bar_pull_handle: cabinet/drawer bar pull #42, [family] duct_takeoff_starting_collar: round-duct start collar #43, [family] single_row_deep_groove_ball_bearing: ISO 15 6000-series open bearing #44, [family-assembly] truss_half_coupler_hook: rigging half coupler / hook clamp #47, [family] quarter_turn_cam_latch: Southco E5-class quarter-turn cam latch #48, [family] vertical_latch_toggle_clamp: GN 851.1 vertical latch toggle clamp #50, [family] metric plastic cable gland #52, [family-assembly] Add t_handle_ball_lock_pin #54, [family-assembly] window_cam_lock: AmesburyTruth 17 Series cam lock #56. CI already tells each of them exactly this in a warning annotation..github/workflows/family-pr-checks.yml, movepreview_hard_zoom.pngfrom step 3b (warn) into step 3's required-files loop, restore the "seven files" wording in the step-3 error message, the header comment, CONTRIBUTING.md's gate table, and drop the "warns while … backfill" caveat.Steps 1 and 2 can happen in any order; step 3 only after both are done, so no PR goes red for something its author could not have produced.