Framework Proxy Autodetection

[davide-aldegheri]

Hi there, recently I've updated your asset to the latest version (2.8.1) to use the proxy autodetect experimental feature.
I've noticed a little bug with the FrameworkProxyDetector class. In this one in the GetProxy function you are checking the Scheme of the proxy by looking with StartsWith("http://") (or socks://) however this is always failing because the actual proxy scheme has no authority in it, it always returns either 'http' or 'https' or 'socks' so it will always fail to set it.

Another nice to have thing would be to also add Exceptions after setting the proxy, somthing like

HTTPManager.Proxy.Exceptions = new List<string>();
 if (systemProxy.BypassProxyOnLocal)//systemProxy is found with WebRequest.GetSystemWebProxy()
 {
       HTTPManager.Proxy.Exceptions.Add("localhost");
 }

 if (systemProxy.BypassList != null)
 {
     HTTPManager.Proxy.Exceptions.AddRange(systemProxy.BypassList);
 }

Thank you very much for your work!

[Benedicht]

Thanks for the report!

The problem with WebProxy.BypassList is that it's a list of regular expressions.

[Benedicht]

The next release will contain the fixes and usage of BypassProxyOnLocal to add "localhost" and "127.0.0.1" to the Exceptions list.

I'm still thinking about the usage of BypassList. Either i could just read the registry instead of using framework's WebRequest.GetSystemWebProxy(), or add support for regex entries in the exception list.

[davide-aldegheri]

Amazing, thanks for the quick fixes. Maybe reading the registry is quicker than supporting a regex just for this.

[davide-aldegheri]

Hey there, in the end I've tried your latest release and found the fixes you made for the autodetection.
To address the BypassList I've actually did a workaround reading the registry and replacing the * to make it work with your asset. So things like *.google.com would safely be added to the exceptions list. (On Windows)

if (systemProxy.BypassList != null)
            {
                using (var key = Registry.CurrentUser.OpenSubKey(@"SOFTWARE\Microsoft\Windows\CurrentVersion\Internet Settings"))
                {
                    if (key != null)
                    {
                        var proxyOverride = key.GetValue("ProxyOverride")?.ToString();
                        if (!string.IsNullOrEmpty(proxyOverride))
                        {
                            var exceptions = proxyOverride.Split(';');
                            for (var i = 0; i < exceptions.Length; i++)
                            {
                                if (exceptions[i].StartsWith("*")) exceptions[i] = exceptions[i].Remove(0, 1);
                            }
                            HTTPManager.Proxy.Exceptions.AddRange(exceptions.Where(e => !e.Equals("<local>")));
                        }
                    }
                }
            }

Thanks again!