Skip to content

Commit 13f8d3a

Browse files
authored
fix(teleport): restore ratio semantics to match backend config (#497)
1 parent c0982ad commit 13f8d3a

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

miniapps/teleport/src/App.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -472,10 +472,10 @@ describe('Teleport App', () => {
472472
fireEvent.click(screen.getByTestId('target-button'))
473473

474474
await waitFor(() => {
475-
expect(screen.getByText('1 BFT = 24.03846154 BFM')).toBeInTheDocument()
476-
expect(screen.getByText('1 BFM = 0.0416 BFT')).toBeInTheDocument()
475+
expect(screen.getByText('1 BFT = 0.0416 BFM')).toBeInTheDocument()
476+
expect(screen.getByText('1 BFM = 24.03846154 BFT')).toBeInTheDocument()
477477
expect(
478-
screen.getAllByText((_, node) => node?.textContent?.includes('240384.61538462 BFM') ?? false)
478+
screen.getAllByText((_, node) => node?.textContent?.includes('416 BFM') ?? false)
479479
.length,
480480
).toBeGreaterThan(0)
481481
})

miniapps/teleport/src/App.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,8 @@ const formatRatioRate = (
265265
if (!ratio) return '0';
266266
const numerator = Number(ratio.numerator);
267267
const denominator = Number(ratio.denominator);
268-
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || numerator === 0) return '0';
269-
return (denominator / numerator).toFixed(8).replace(/\.?0+$/, '');
268+
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || denominator === 0) return '0';
269+
return (numerator / denominator).toFixed(8).replace(/\.?0+$/, '');
270270
};
271271

272272
const formatInverseRatioRate = (
@@ -275,8 +275,8 @@ const formatInverseRatioRate = (
275275
if (!ratio) return '0';
276276
const numerator = Number(ratio.numerator);
277277
const denominator = Number(ratio.denominator);
278-
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || denominator === 0) return '0';
279-
return (numerator / denominator).toFixed(8).replace(/\.?0+$/, '');
278+
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || numerator === 0) return '0';
279+
return (denominator / numerator).toFixed(8).replace(/\.?0+$/, '');
280280
};
281281

282282
export default function App() {
@@ -612,7 +612,7 @@ export default function App() {
612612
if (!selectedAsset || !amount) return '0';
613613
const amountNum = Number(amount);
614614
if (!Number.isFinite(amountNum)) return '0';
615-
const ratioNum = Number(selectedAsset.ratio.denominator) / Number(selectedAsset.ratio.numerator);
615+
const ratioNum = Number(selectedAsset.ratio.numerator) / Number(selectedAsset.ratio.denominator);
616616
if (!Number.isFinite(ratioNum)) return '0';
617617
return (amountNum * ratioNum).toFixed(8).replace(/\.?0+$/, '');
618618
}, [selectedAsset, amount]);

0 commit comments

Comments
 (0)