Skip to content
This repository was archived by the owner on Mar 14, 2022. It is now read-only.
This repository was archived by the owner on Mar 14, 2022. It is now read-only.

Unsuccessful Authorisation saved as successful #17

@Jurgen8en

Description

@Jurgen8en

Because reason is empty, the payment is marked as Authorised !!
An example of a real Adyen notification:

originalReference=
reason=
additionalData.hmacSignature=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
merchantAccountCode=xxxxxxxxxx
eventCode=AUTHORISATION
operations=
success=false
paymentMethod=ideal
currency=EUR
pspReference=4755881009859805
merchantReference=*****3051-7409
value=4990
live=true
eventDate=2020-04-28T19:10:18.42Z

This code is wrong.

          if (AdyenBridgeInterface::AUTHORISATION === $httpRequest->request['eventCode']) {
                if (true === filter_var($httpRequest->request['success'], FILTER_VALIDATE_BOOLEAN)) {
                    $httpRequest->request['authResult'] = AdyenBridgeInterface::AUTHORISED;
                } elseif (!empty($httpRequest->request['reason'])) {
                    $httpRequest->request['authResult'] = AdyenBridgeInterface::REFUSED;
                }
            }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions