[Debian packaging] Proto files distributed pre-compiled

[manuwarfare]

Dear Maintainer,

I'm packaging this software for distribution in the official Debian repositories, and I notice that there are some files that should be compiled using the protobuf tool. However, these /bitbox02/communication/generated/* files are distributed precompiled. Now, my question is, is there any way to distribute the source files so they are generated by protobuf during the build?

Regards,

[NickeZ]

make -C py should generate the protobuf files I think

[manuwarfare]

The make -C py command fails to generate the protobuf files if the source .proto files are not included in the repository. Currently, I only see the precompiled *_pb2.py files, but I need the original .proto files (such as antiklepto.proto, backup_commands.proto, etc.) so that Debian can compile them during the build process.

[NickeZ]

the proto files are in the messages folder in the top directory.

$ ls messages
antiklepto.proto          bitbox02_system.proto     cardano.proto             eth.proto                 mnemonic.proto
backup_commands.proto     bluetooth.proto           CMakeLists.txt            hww.proto                 perform_attestation.proto
backup.proto              btc.proto                 common.proto              keystore.proto            system.proto

[benma]

@manuwarfare why do you even want to re-generate these files? These generated files are part of our official package and tested to work. Regenerating them poses a (small) risk of breakage, but I am curious what the benefit of it even is. The generated files are not binaries after all and still readable Python.

[manuwarfare]

@manuwarfare why do you even want to re-generate these files? These generated files are part of our official package and tested to work. Regenerating them poses a (small) risk of breakage, but I am curious what the benefit of it even is. The generated files are not binaries after all and still readable Python.

Sorry for not replying sooner... the thing is, in Debian you can't include precompiled code; everything must be built from the original source, even if it's just simple documentation (to give an example).

[manuwarfare]

the proto files are in the messages folder in the top directory.

$ ls messages
antiklepto.proto          bitbox02_system.proto     cardano.proto             eth.proto                 mnemonic.proto
backup_commands.proto     bluetooth.proto           CMakeLists.txt            hww.proto                 perform_attestation.proto
backup.proto              btc.proto                 common.proto              keystore.proto            system.proto

@benma Do you think it's possible to add these files to the package you upload to pypi.org?

I've almost got the package ready to upload to the Debian archive; I just need to work out the proto files.

Show Debian packaging here: https://salsa.debian.org/python-team/packages/python-bitbox02