Skip to content

i18n: missing ok.po msgids, stop notification bypasses og.app.tr #112

@BoringMan314

Description

@BoringMan314

When testing with zh_TW, simplified Chinese strings still appear — e.g. stop notification shows 自动钓鱼 已停止, and the info panel shows 轮次, 开启, 任务结束.


Needs code changes (adding .po entries alone will not fix)

Location Issue
ok/gui/MainWindow.pyshow_notification Uses QCoreApplication.translate(app, …); does not consult ok.po
ok/gui/util/app.pyshow_info_bar Same
ok/task/TaskExecutor.py On stop: emit('Stopped', task.name, …) — task name does not go through og.app.tr

→ Please switch to og.app.tr() (consistent with TaskTab).


Already wired — only ok.po entries needed

Location Note
ok/gui/tasks/TaskTab.py info_set keys/values already use og.app.tr()
src/tasks/*.py Static simplified-Chinese msgids are fine; no tr() needed in tasks

ok.po is currently missing msgids that the UI will look up, including: 轮次, 成功次数, 失败次数, 当前阶段, 失败原因, 开启/关闭, 任务结束, plus runtime logs, notify messages, and stage strings from various tasks.


Request

  1. Switch the notification path to og.app.tr
  2. Add the missing msgids (7 locales)
  3. Confirm runtime loads ok.mo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions