Skip to content

Commit 99bd323

Browse files
authored
feat!: support users v2 api (#190)
BREAKING CHANGE: all "Q" parameters were renamed to "Query" to ensure consistency in the entire codebase Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
1 parent 511cdfb commit 99bd323

13 files changed

Lines changed: 1060 additions & 24 deletions

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,8 @@ fmt.Printf("Quality Gate: %s\n", status.ProjectStatus.Status)
321321
**User management:**
322322

323323
```go
324-
users, _, err := client.Users.Search(ctx, &sonar.UsersSearchOption{
325-
Q: sonar.String("john"),
324+
users, _, err := client.Users.Search(&sonar.UsersSearchOption{
325+
Query: "john",
326326
})
327327
for _, user := range users.Users {
328328
fmt.Printf("User: %s (%s)\n", user.Name, user.Login)

integration_testing/ce_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ var _ = Describe("Ce Service", Ordered, func() {
110110

111111
It("should search CE tasks by query", func() {
112112
result, resp, err := client.Ce.Activity(&sonar.CeActivityOption{
113-
Q: testProject.Project.Key,
113+
Query: testProject.Project.Key,
114114
})
115115
Expect(err).NotTo(HaveOccurred())
116116
Expect(resp.StatusCode).To(Equal(http.StatusOK))

integration_testing/components_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ var _ = Describe("Components Service", Ordered, func() {
480480
Expect(err).NotTo(HaveOccurred())
481481
Expect(resp.StatusCode).To(Equal(http.StatusOK))
482482
Expect(result.Name).NotTo(BeEmpty())
483-
Expect(result.Q).To(Equal("TRK"))
483+
Expect(result.Query).To(Equal("TRK"))
484484
})
485485

486486
Context("parameter validation", func() {

integration_testing/helpers/cleanup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func cleanupOrphanedUsers(client *sonar.Client, _ time.Duration) error {
165165
LastConnectedAfter: "",
166166
LastConnectedBefore: "",
167167
Managed: false,
168-
Q: E2EResourcePrefix,
168+
Query: E2EResourcePrefix,
169169
SlLastConnectedAfter: "",
170170
SlLastConnectedBefore: "",
171171
})

integration_testing/users_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ var _ = Describe("Users Service", Ordered, func() {
8282
It("should filter users by query", func() {
8383
//nolint:staticcheck // Using deprecated API until v2 API is implemented
8484
result, resp, err := client.Users.Search(&sonar.UsersSearchOption{
85-
Q: "admin",
85+
Query: "admin",
8686
})
8787
Expect(err).NotTo(HaveOccurred())
8888
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -101,7 +101,7 @@ var _ = Describe("Users Service", Ordered, func() {
101101
It("should return empty list for non-matching query", func() {
102102
//nolint:staticcheck // Using deprecated API until v2 API is implemented
103103
result, resp, err := client.Users.Search(&sonar.UsersSearchOption{
104-
Q: "nonexistentuserxyz123",
104+
Query: "nonexistentuserxyz123",
105105
})
106106
Expect(err).NotTo(HaveOccurred())
107107
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -533,7 +533,7 @@ var _ = Describe("Users Service", Ordered, func() {
533533
// Verify new login exists
534534
//nolint:staticcheck // Using deprecated API until v2 API is implemented
535535
result, _, err := client.Users.Search(&sonar.UsersSearchOption{
536-
Q: newLogin,
536+
Query: newLogin,
537537
})
538538
Expect(err).NotTo(HaveOccurred())
539539
found := false
@@ -601,7 +601,7 @@ var _ = Describe("Users Service", Ordered, func() {
601601
//nolint:staticcheck // Using deprecated API until v2 API is implemented
602602
result, resp, err := client.Users.Groups(&sonar.UsersGroupsOption{
603603
Login: "admin",
604-
Q: "sonar",
604+
Query: "sonar",
605605
})
606606
Expect(err).NotTo(HaveOccurred())
607607
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -776,7 +776,7 @@ var _ = Describe("Users Service", Ordered, func() {
776776
// Verify user is deactivated
777777
//nolint:staticcheck // Using deprecated API until v2 API is implemented
778778
searchResult, _, err := client.Users.Search(&sonar.UsersSearchOption{
779-
Q: login,
779+
Query: login,
780780
Deactivated: true,
781781
})
782782
Expect(err).NotTo(HaveOccurred())
@@ -943,7 +943,7 @@ var _ = Describe("Users Service", Ordered, func() {
943943
// Step 2: Search and verify
944944
//nolint:staticcheck // Using deprecated API until v2 API is implemented
945945
searchResult, _, err := client.Users.Search(&sonar.UsersSearchOption{
946-
Q: login,
946+
Query: login,
947947
})
948948
Expect(err).NotTo(HaveOccurred())
949949
found := false

0 commit comments

Comments
 (0)