Skip to content

Commit ce637aa

Browse files
BoxBoxJasonBoxBoxJason
authored
feat: create usage constants (#194)
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
1 parent 6ba736f commit ce637aa

49 files changed

Lines changed: 1035 additions & 551 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎integration_testing/alm_integrations_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ var _ = Describe("AlmIntegrations Service", Ordered, func() {
118118
resp, err := client.AlmIntegrations.ImportAzureProject(&sonar.AlmIntegrationsImportAzureProjectOptions{
119119
ProjectName: "test-project",
120120
RepositoryName: "test-repo",
121-
NewCodeDefinitionType: "NUMBER_OF_DAYS",
121+
NewCodeDefinitionType: sonar.NewCodePeriodTypeNumberOfDays,
122122
NewCodeDefinitionValue: 0,
123123
})
124124
Expect(err).To(HaveOccurred())
@@ -130,7 +130,7 @@ var _ = Describe("AlmIntegrations Service", Ordered, func() {
130130
resp, err := client.AlmIntegrations.ImportAzureProject(&sonar.AlmIntegrationsImportAzureProjectOptions{
131131
ProjectName: "test-project",
132132
RepositoryName: "test-repo",
133-
NewCodeDefinitionType: "NUMBER_OF_DAYS",
133+
NewCodeDefinitionType: sonar.NewCodePeriodTypeNumberOfDays,
134134
NewCodeDefinitionValue: 100,
135135
})
136136
Expect(err).To(HaveOccurred())

‎integration_testing/ce_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var _ = Describe("Ce Service", Ordered, func() {
8383

8484
It("should list CE tasks filtered by status", func() {
8585
result, resp, err := client.Ce.Activity(&sonar.CeActivityOptions{
86-
Statuses: []string{"SUCCESS"},
86+
Statuses: []string{sonar.TaskStatusSuccess},
8787
})
8888
Expect(err).NotTo(HaveOccurred())
8989
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -92,7 +92,7 @@ var _ = Describe("Ce Service", Ordered, func() {
9292

9393
It("should list CE tasks filtered by type", func() {
9494
result, resp, err := client.Ce.Activity(&sonar.CeActivityOptions{
95-
Type: "REPORT",
95+
Type: sonar.TaskTypeReport,
9696
})
9797
Expect(err).NotTo(HaveOccurred())
9898
Expect(resp.StatusCode).To(Equal(http.StatusOK))

‎integration_testing/components_test.go‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ var _ = Describe("Components Service", Ordered, func() {
3737
Describe("Search", func() {
3838
It("should search for projects", func() {
3939
result, resp, err := client.Components.Search(&sonar.ComponentsSearchOptions{
40-
Qualifiers: []string{"TRK"},
40+
Qualifiers: []string{sonar.ProjectQualifierTRK},
4141
})
4242
Expect(err).NotTo(HaveOccurred())
4343
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -47,7 +47,7 @@ var _ = Describe("Components Service", Ordered, func() {
4747

4848
It("should search projects with pagination", func() {
4949
result, resp, err := client.Components.Search(&sonar.ComponentsSearchOptions{
50-
Qualifiers: []string{"TRK"},
50+
Qualifiers: []string{sonar.ProjectQualifierTRK},
5151
PaginationArgs: sonar.PaginationArgs{
5252
PageSize: 5,
5353
},
@@ -81,7 +81,7 @@ var _ = Describe("Components Service", Ordered, func() {
8181

8282
// Search for it
8383
result, resp, err := client.Components.Search(&sonar.ComponentsSearchOptions{
84-
Qualifiers: []string{"TRK"},
84+
Qualifiers: []string{sonar.ProjectQualifierTRK},
8585
Query: query,
8686
})
8787
Expect(err).NotTo(HaveOccurred())
@@ -216,7 +216,7 @@ var _ = Describe("Components Service", Ordered, func() {
216216
Expect(resp.StatusCode).To(Equal(http.StatusOK))
217217
Expect(result).NotTo(BeNil())
218218
Expect(result.Component.Key).To(Equal(projectKey))
219-
Expect(result.Component.Qualifier).To(Equal("TRK"))
219+
Expect(result.Component.Qualifier).To(Equal(sonar.ProjectQualifierTRK))
220220
})
221221

222222
It("should return ancestors for project", func() {
@@ -288,7 +288,7 @@ var _ = Describe("Components Service", Ordered, func() {
288288
It("should get tree with all strategy", func() {
289289
result, resp, err := client.Components.Tree(&sonar.ComponentsTreeOptions{
290290
Component: projectKey,
291-
Strategy: "all",
291+
Strategy: sonar.MeasureStrategyAll,
292292
})
293293
Expect(err).NotTo(HaveOccurred())
294294
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -298,7 +298,7 @@ var _ = Describe("Components Service", Ordered, func() {
298298
It("should get tree with children strategy", func() {
299299
result, resp, err := client.Components.Tree(&sonar.ComponentsTreeOptions{
300300
Component: projectKey,
301-
Strategy: "children",
301+
Strategy: sonar.MeasureStrategyChildren,
302302
})
303303
Expect(err).NotTo(HaveOccurred())
304304
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -308,7 +308,7 @@ var _ = Describe("Components Service", Ordered, func() {
308308
It("should get tree with leaves strategy", func() {
309309
result, resp, err := client.Components.Tree(&sonar.ComponentsTreeOptions{
310310
Component: projectKey,
311-
Strategy: "leaves",
311+
Strategy: sonar.MeasureStrategyLeaves,
312312
})
313313
Expect(err).NotTo(HaveOccurred())
314314
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -416,7 +416,7 @@ var _ = Describe("Components Service", Ordered, func() {
416416

417417
It("should get more suggestions for TRK qualifier", func() {
418418
result, resp, err := client.Components.Suggestions(&sonar.ComponentsSuggestionsOptions{
419-
More: "TRK",
419+
More: sonar.ProjectQualifierTRK,
420420
})
421421
Expect(err).NotTo(HaveOccurred())
422422
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -480,7 +480,7 @@ var _ = Describe("Components Service", Ordered, func() {
480480
Expect(err).NotTo(HaveOccurred())
481481
Expect(resp.StatusCode).To(Equal(http.StatusOK))
482482
Expect(result.Name).NotTo(BeEmpty())
483-
Expect(result.Query).To(Equal("TRK"))
483+
Expect(result.Query).To(Equal(sonar.ProjectQualifierTRK))
484484
})
485485

486486
Context("parameter validation", func() {

‎integration_testing/hotspots_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ var _ = Describe("Hotspots Service", Ordered, func() {
9494
It("should search hotspots with status filter", func() {
9595
result, resp, err := client.Hotspots.Search(&sonar.HotspotsSearchOptions{
9696
Project: projectKey,
97-
Status: "TO_REVIEW",
97+
Status: sonar.HotspotStatusToReview,
9898
})
9999
Expect(err).NotTo(HaveOccurred())
100100
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -174,7 +174,7 @@ var _ = Describe("Hotspots Service", Ordered, func() {
174174
It("should list hotspots with status filter", func() {
175175
result, resp, err := client.Hotspots.List(&sonar.HotspotsListOptions{
176176
Project: projectKey,
177-
Status: "TO_REVIEW",
177+
Status: sonar.HotspotStatusToReview,
178178
})
179179
Expect(err).NotTo(HaveOccurred())
180180
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -376,7 +376,7 @@ var _ = Describe("Hotspots Service", Ordered, func() {
376376

377377
It("should fail without required hotspot key", func() {
378378
resp, err := client.Hotspots.ChangeStatus(&sonar.HotspotsChangeStatusOptions{
379-
Status: "REVIEWED",
379+
Status: sonar.HotspotStatusReviewed,
380380
})
381381
Expect(err).To(HaveOccurred())
382382
Expect(err.Error()).To(ContainSubstring("Hotspot"))
@@ -397,8 +397,8 @@ var _ = Describe("Hotspots Service", Ordered, func() {
397397
It("should fail with non-existent hotspot key", func() {
398398
resp, err := client.Hotspots.ChangeStatus(&sonar.HotspotsChangeStatusOptions{
399399
Hotspot: "AXxxxxxxxxxxxxxxxxxx",
400-
Status: "REVIEWED",
401-
Resolution: "SAFE",
400+
Status: sonar.HotspotStatusReviewed,
401+
Resolution: sonar.HotspotResolutionSafe,
402402
})
403403
Expect(err).To(HaveOccurred())
404404
if resp != nil {

‎integration_testing/issues_test.go‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ var _ = Describe("Issues Service", Ordered, func() {
8989
It("should search issues with impact severities filter", func() {
9090
result, resp, err := client.Issues.Search(&sonar.IssuesSearchOptions{
9191
Projects: []string{projectKey},
92-
ImpactSeverities: []string{"HIGH", "MEDIUM"},
92+
ImpactSeverities: []string{sonar.RuleImpactSeverityHigh, sonar.RuleImpactSeverityMedium},
9393
})
9494
Expect(err).NotTo(HaveOccurred())
9595
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -99,7 +99,7 @@ var _ = Describe("Issues Service", Ordered, func() {
9999
It("should search issues with issue statuses filter", func() {
100100
result, resp, err := client.Issues.Search(&sonar.IssuesSearchOptions{
101101
Projects: []string{projectKey},
102-
IssueStatuses: []string{"OPEN", "CONFIRMED"},
102+
IssueStatuses: []string{sonar.IssueStatusOpen, sonar.IssueStatusConfirmed},
103103
})
104104
Expect(err).NotTo(HaveOccurred())
105105
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -109,7 +109,7 @@ var _ = Describe("Issues Service", Ordered, func() {
109109
It("should search issues with clean code categories filter", func() {
110110
result, resp, err := client.Issues.Search(&sonar.IssuesSearchOptions{
111111
Projects: []string{projectKey},
112-
CleanCodeAttributeCategories: []string{"INTENTIONAL", "CONSISTENT"},
112+
CleanCodeAttributeCategories: []string{sonar.CleanCodeAttributeCategoryIntentional, sonar.CleanCodeAttributeCategoryConsistent},
113113
})
114114
Expect(err).NotTo(HaveOccurred())
115115
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -408,7 +408,7 @@ var _ = Describe("Issues Service", Ordered, func() {
408408

409409
It("should fail without required issue key", func() {
410410
result, resp, err := client.Issues.DoTransition(&sonar.IssuesDoTransitionOptions{
411-
Transition: "confirm",
411+
Transition: sonar.IssueTransitionConfirm,
412412
})
413413
Expect(err).To(HaveOccurred())
414414
Expect(err.Error()).To(ContainSubstring("Issue"))
@@ -431,7 +431,7 @@ var _ = Describe("Issues Service", Ordered, func() {
431431
It("should fail with non-existent issue key", func() {
432432
result, resp, err := client.Issues.DoTransition(&sonar.IssuesDoTransitionOptions{
433433
Issue: nonExistentIssueKey,
434-
Transition: "confirm",
434+
Transition: sonar.IssueTransitionConfirm,
435435
})
436436
Expect(err).To(HaveOccurred())
437437
Expect(result).To(BeNil())
@@ -498,7 +498,7 @@ var _ = Describe("Issues Service", Ordered, func() {
498498

499499
It("should fail without required issue key", func() {
500500
result, resp, err := client.Issues.SetSeverity(&sonar.IssuesSetSeverityOptions{
501-
Severity: "MAJOR",
501+
Severity: sonar.RuleSeverityMajor,
502502
})
503503
Expect(err).To(HaveOccurred())
504504
Expect(err.Error()).To(ContainSubstring("Issue"))
@@ -511,7 +511,7 @@ var _ = Describe("Issues Service", Ordered, func() {
511511
It("should fail with non-existent issue key", func() {
512512
result, resp, err := client.Issues.SetSeverity(&sonar.IssuesSetSeverityOptions{
513513
Issue: nonExistentIssueKey,
514-
Severity: "MAJOR",
514+
Severity: sonar.RuleSeverityMajor,
515515
})
516516
Expect(err).To(HaveOccurred())
517517
Expect(result).To(BeNil())
@@ -576,7 +576,7 @@ var _ = Describe("Issues Service", Ordered, func() {
576576

577577
It("should fail without required issue key", func() {
578578
result, resp, err := client.Issues.SetType(&sonar.IssuesSetTypeOptions{
579-
Type: "BUG",
579+
Type: sonar.RuleTypeBug,
580580
})
581581
Expect(err).To(HaveOccurred())
582582
Expect(err.Error()).To(ContainSubstring("Issue"))
@@ -599,7 +599,7 @@ var _ = Describe("Issues Service", Ordered, func() {
599599
It("should fail with non-existent issue key", func() {
600600
result, resp, err := client.Issues.SetType(&sonar.IssuesSetTypeOptions{
601601
Issue: nonExistentIssueKey,
602-
Type: "BUG",
602+
Type: sonar.RuleTypeBug,
603603
})
604604
Expect(err).To(HaveOccurred())
605605
Expect(result).To(BeNil())

‎integration_testing/measures_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ var _ = Describe("Measures Service", Ordered, func() {
235235
result, resp, err := client.Measures.ComponentTree(&sonar.MeasuresComponentTreeOptions{
236236
Component: projectKey,
237237
MetricKeys: []string{"ncloc"},
238-
Strategy: "children",
238+
Strategy: sonar.MeasureStrategyChildren,
239239
})
240240
Expect(err).NotTo(HaveOccurred())
241241
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -246,7 +246,7 @@ var _ = Describe("Measures Service", Ordered, func() {
246246
result, resp, err := client.Measures.ComponentTree(&sonar.MeasuresComponentTreeOptions{
247247
Component: projectKey,
248248
MetricKeys: []string{"ncloc"},
249-
Strategy: "leaves",
249+
Strategy: sonar.MeasureStrategyLeaves,
250250
})
251251
Expect(err).NotTo(HaveOccurred())
252252
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -257,7 +257,7 @@ var _ = Describe("Measures Service", Ordered, func() {
257257
result, resp, err := client.Measures.ComponentTree(&sonar.MeasuresComponentTreeOptions{
258258
Component: projectKey,
259259
MetricKeys: []string{"ncloc"},
260-
Strategy: "all",
260+
Strategy: sonar.MeasureStrategyAll,
261261
})
262262
Expect(err).NotTo(HaveOccurred())
263263
Expect(resp.StatusCode).To(Equal(http.StatusOK))
@@ -268,7 +268,7 @@ var _ = Describe("Measures Service", Ordered, func() {
268268
result, resp, err := client.Measures.ComponentTree(&sonar.MeasuresComponentTreeOptions{
269269
Component: projectKey,
270270
MetricKeys: []string{"ncloc"},
271-
MetricSortFilter: "withMeasuresOnly",
271+
MetricSortFilter: sonar.MeasuresMetricSortFilterWithMeasuresOnly,
272272
MetricSort: "ncloc",
273273
Sort: []string{"metric"},
274274
})

0 commit comments

Comments
 (0)