From 67303bb9281d9c2a291b9e01cbbb0c46b92bcaed Mon Sep 17 00:00:00 2001 From: Beckett Frey Date: Tue, 14 Apr 2026 16:17:46 -0500 Subject: [PATCH 1/2] Fix button width inconsistency --- .pre-commit-config.yaml | 8 ++++++-- src/voxkit/gui/pages/datasets/datasets_page.py | 5 +---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f544bc6..3da7c96 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -14,10 +14,14 @@ repos: args: [--fix] - id: ruff-format - - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.19.1 + - repo: local hooks: - id: mypy + name: mypy + entry: uv run --only-group dev mypy . + language: system + types: [python] + pass_filenames: false - repo: https://github.com/pre-commit/pre-commit-hooks rev: v6.0.0 diff --git a/src/voxkit/gui/pages/datasets/datasets_page.py b/src/voxkit/gui/pages/datasets/datasets_page.py index e667e4e..fc9159a 100644 --- a/src/voxkit/gui/pages/datasets/datasets_page.py +++ b/src/voxkit/gui/pages/datasets/datasets_page.py @@ -539,18 +539,15 @@ def _create_alignment_action_buttons(self, alignment: alignments.AlignmentMetada layout.setContentsMargins(5, 2, 5, 2) layout.setSpacing(5) - button_style = Buttons.SUCCESS_SMALL - # Delete button delete_btn = QPushButton("Delete") - delete_btn.setMaximumWidth(60) delete_btn.setStyleSheet(Buttons.DELETE_SMALL) delete_btn.clicked.connect(lambda: self._delete_alignment(alignment)) layout.addWidget(delete_btn) # View button view_btn = QPushButton("View") - view_btn.setStyleSheet(button_style) + view_btn.setStyleSheet(Buttons.SUCCESS_SMALL) view_btn.clicked.connect(lambda: self._view_alignment(alignment)) layout.addWidget(view_btn) From b1ba441c3065d6d92d5dacc88debdd4484a66461 Mon Sep 17 00:00:00 2001 From: Beckett Frey Date: Tue, 14 Apr 2026 16:27:56 -0500 Subject: [PATCH 2/2] Migrate to table style --- .../frameworks/categorical_table/categorical_table.py | 1 - src/voxkit/gui/pages/datasets/datasets_page.py | 10 ++++------ src/voxkit/gui/styles/__init__.py | 2 ++ 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/voxkit/gui/frameworks/categorical_table/categorical_table.py b/src/voxkit/gui/frameworks/categorical_table/categorical_table.py index 6f7a588..feca954 100644 --- a/src/voxkit/gui/frameworks/categorical_table/categorical_table.py +++ b/src/voxkit/gui/frameworks/categorical_table/categorical_table.py @@ -291,7 +291,6 @@ def update_display(self): button_layout.setAlignment(Qt.AlignmentFlag.AlignCenter) view_btn = QPushButton("View") - view_btn.setFixedSize(60, 24) view_btn.setStyleSheet(Buttons.TABLE_VIEW) view_btn.clicked.connect(lambda checked, idx=row_idx: self.view_item_details(idx)) button_layout.addWidget(view_btn) diff --git a/src/voxkit/gui/pages/datasets/datasets_page.py b/src/voxkit/gui/pages/datasets/datasets_page.py index fc9159a..d58593c 100644 --- a/src/voxkit/gui/pages/datasets/datasets_page.py +++ b/src/voxkit/gui/pages/datasets/datasets_page.py @@ -547,7 +547,7 @@ def _create_alignment_action_buttons(self, alignment: alignments.AlignmentMetada # View button view_btn = QPushButton("View") - view_btn.setStyleSheet(Buttons.SUCCESS_SMALL) + view_btn.setStyleSheet(Buttons.TABLE_VIEW) view_btn.clicked.connect(lambda: self._view_alignment(alignment)) layout.addWidget(view_btn) @@ -807,15 +807,13 @@ def _create_dataset_action_buttons(self, dataset_meta: DatasetMetadata): """ widget = QWidget() layout = QHBoxLayout(widget) - layout.setContentsMargins(0, 0, 0, 0) + layout.setContentsMargins(5, 2, 5, 2) + layout.setSpacing(5) layout.setAlignment(Qt.AlignmentFlag.AlignCenter) - button_style = Buttons.TABLE_VIEW - # Details button details_btn = QPushButton("Details") - details_btn.setFixedSize(80, 24) - details_btn.setStyleSheet(button_style) + details_btn.setStyleSheet(Buttons.TABLE_VIEW) details_btn.clicked.connect(lambda: self._view_dataset_details(dataset_meta)) layout.addWidget(details_btn) diff --git a/src/voxkit/gui/styles/__init__.py b/src/voxkit/gui/styles/__init__.py index 383e5ec..b0abc8c 100644 --- a/src/voxkit/gui/styles/__init__.py +++ b/src/voxkit/gui/styles/__init__.py @@ -257,6 +257,8 @@ class Buttons: font-size: 12px; font-weight: bold; color: {Colors.TEXT_SECONDARY}; + min-width: 60px; + min-height: 24px; }} QPushButton:hover {{ background-color: {Colors.LIGHT_GRAY};