Get rid of Static Textures in Direct-X.

Fix drawing in Direct-X to not overlay icons.

Author: Brandon-T

RemoteInput/Platform/NativeHooks_Windows.cxx

@@ -46,6 +46,7 @@ std::unique_ptr<Hook> directx_device9_endscene_hook{nullptr};
 std::unique_ptr<Hook> directx_device9_reset_hook{nullptr};
 std::unique_ptr<Hook> directx_device11_swapchain_present_hook{nullptr};
 
+IDirect3DTexture9* debug_texture = nullptr;
 IDirect3DDevice9* current_dx_device = nullptr;
 void HookD3D9Device(IDirect3DDevice9* pDevice, bool force = false) noexcept;
 
@@ -1015,28 +1016,30 @@ HRESULT __stdcall D3D9Device_EndScene(IDirect3DDevice9* device) noexcept
         D3DVIEWPORT9 viewport;
         if (SUCCEEDED(device->GetViewport(&viewport)))
         {
+            std::int32_t x = 0;
+            std::int32_t y = 0;
             std::int32_t width = static_cast<std::int32_t>(viewport.Width);
             std::int32_t height = static_cast<std::int32_t>(viewport.Height);
 
-            std::int32_t x = 0;
-            std::int32_t y = 0;
+            std::int32_t applet_x = 0;
+            std::int32_t applet_y = 0;
             std::size_t applet_width = 0;
             std::size_t applet_height = 0;
 
-            control_center->get_applet_dimensions(&x, &y, &applet_width, &applet_height);
-            control_center->set_target_dimensions(static_cast<std::int32_t>(applet_width), static_cast<std::int32_t>(applet_height));
+            control_center->get_applet_dimensions(&applet_x, &applet_y, &applet_width, &applet_height);
 
-            /*if (width != applet_width || height != applet_height)
-            {
-                // Possibly menu open, render normally
-                return directx_device9_endscene_hook->call<HRESULT, decltype(D3D9Device_EndScene)>(device);
-            }*/
-
-            control_center->set_target_dimensions(static_cast<std::int32_t>(width), static_cast<std::int32_t>(height));
+            // Terrible. RuneLite's UI flickers with icons because it draws like trash
+            // So we need to feed the client the Applet's Width/Height and not the Viewport's Width/Height
+            // Even though the ViewPort is what's being drawn on. RL draws outside that.
+            control_center->set_target_dimensions(applet_width, applet_height);
 
             bool minimized = false;
             ImageFormat image_format = control_center->get_image_format();
-            dx_read_pixels(device, control_center->get_image(), width, height, minimized, image_format);
+
+            if (width <= applet_width && height == applet_height)
+            {
+                dx_read_pixels(device, control_center->get_image(), width, height, minimized, image_format);
+            }
 
             IDirect3DStateBlock9* block;
             device->CreateStateBlock(D3DSBT_ALL, &block);
@@ -1046,19 +1049,21 @@ HRESULT __stdcall D3D9Device_EndScene(IDirect3DDevice9* device) noexcept
             device->SetRenderState(D3DRS_FOGENABLE, FALSE);
             device->SetRenderState(D3DRS_ZENABLE, D3DZB_FALSE);
             device->SetRenderState(D3DRS_CULLMODE, D3DCULL_NONE);
-            device->SetRenderState(D3DRS_ALPHABLENDENABLE, TRUE); //DISABLED
+            device->SetRenderState(D3DRS_ALPHABLENDENABLE, TRUE);
             device->SetRenderState(D3DRS_BLENDOP, D3DBLENDOP_ADD);
             device->SetRenderState(D3DRS_SRCBLEND, D3DBLEND_SRCALPHA);
             device->SetRenderState(D3DRS_DESTBLEND, D3DBLEND_INVSRCALPHA);
 
-            if (control_center->get_debug_graphics() && !minimized)
+            if (width <= applet_width && height == applet_height)
             {
-                static IDirect3DTexture9* texture = nullptr;
-                dx_load_texture(device, texture, image_format, control_center->get_debug_image(), width, height);
-
-                if (texture)
+                if (control_center->get_debug_graphics() && !minimized)
                 {
-                    dx_draw_texture(device, texture, image_format, 0.0, 0.0, static_cast<float>(width), static_cast<float>(height));
+                    dx_load_texture(device, debug_texture, image_format, control_center->get_debug_image(), width, height);
+
+                    if (debug_texture)
+                    {
+                        dx_draw_texture(device, debug_texture, image_format, 0.0, 0.0, static_cast<float>(width), static_cast<float>(height));
+                    }
                 }
             }
 
@@ -1120,6 +1125,12 @@ void HookD3D9Device(IDirect3DDevice9* pDevice, bool force) noexcept
     current_dx_device = pDevice;
     auto* vTable = *reinterpret_cast<DWORD_PTR**>(pDevice);
 
+    // Release the debug texture
+    if (debug_texture)
+    {
+        debug_texture->Release();
+    }
+
     // Hook EndScene
     auto* endscene = reinterpret_cast<decltype(D3D9Device_EndScene)*>(vTable[42]);
     directx_device9_endscene_hook = std::make_unique<Hook>(reinterpret_cast<void*>(endscene), reinterpret_cast<void*>(D3D9Device_EndScene));
@@ -1130,6 +1141,7 @@ void HookD3D9Device(IDirect3DDevice9* pDevice, bool force) noexcept
     directx_device9_reset_hook = std::make_unique<Hook>(reinterpret_cast<void*>(reset), reinterpret_cast<void*>(D3D9Device_Reset));
     directx_device9_reset_hook->apply();
 
+    // Validate that functions were actually hooked
     if (!directx_device9_endscene_hook->is_enabled())
     {
         current_dx_device = nullptr;