Skip to content

Follow-ups from PR #179 review (non-blocking) #180

Description

@C0derTang

Non-blocking findings from the #179 security review, filed per master merge flow:

  1. src/lib/cf/oauth-server.ts getRequestOrigin trusts x-forwarded-host/x-forwarded-proto unconditionally. Safe on Vercel (headers set by the platform; CF also rejects unregistered redirect_uris), but add a comment documenting the trust assumption.
  2. src/app/api/cf/oauth/callback/route.ts signed-out-on-callback returns raw 401 JSON and does not clear the state cookie — redirect to sign-in (same-origin) and delete the cookie instead. UX only.
  3. Dead contract/schema cleanup after OIDC migration: handle_verifications table (schema + drop migration), hasCompileErrorSince(), CfVerifyStartResponse/CfLinkResponse in types.ts. Explicitly a schema/contract issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    model:haikuTrivial/mechanical - haiku agentwave-3Wave 3: integration

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions