Skip to content

Commit 0c05c0a

Browse files
author
Pavel Siska
committed
appFs - Initialize fuse_buf struct to avoid use of uninitialized values
Previously, m_buffer members were manually set in the constructor, but not all fields were guaranteed to be initialized, leading to valgrind warnings about uninitialized reads inside libfuse.
1 parent 603a1fd commit 0c05c0a

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/appFs/appFs.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -363,11 +363,7 @@ static void setFuseOperations(struct fuse_operations* fuseOps)
363363

364364
class AppFsFuseBuffer {
365365
public:
366-
AppFsFuseBuffer()
367-
{
368-
m_buffer.mem = nullptr;
369-
m_buffer.size = 0;
370-
}
366+
AppFsFuseBuffer() = default;
371367

372368
~AppFsFuseBuffer()
373369
{
@@ -378,7 +374,7 @@ class AppFsFuseBuffer {
378374
fuse_buf* getBuffer() { return &m_buffer; }
379375

380376
private:
381-
fuse_buf m_buffer;
377+
fuse_buf m_buffer {};
382378
};
383379

384380
static void fuseLoop(struct fuse_session* session)

0 commit comments

Comments
 (0)